Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make environment variable reading more consistent #540

Open
ghost opened this issue Jun 29, 2020 · 0 comments
Open

Make environment variable reading more consistent #540

ghost opened this issue Jun 29, 2020 · 0 comments
Labels
0 - Backlog New issue, unvetted. maintenance Things need to be changed to prevent future problems.

Comments

@ghost
Copy link

ghost commented Jun 29, 2020

A large number of environment variables can be defined to influence a navajo instance. The reading of happens, unfortunately, in two ways:

  • Via central classes, such as
    • com.dexels.config.runtime.RuntimeConfig
    • com.dexels.config.runtime.TestConfig
  • Ad hoc, in situ.

Some variables are also read in both ways, such as

  • DEVELOP_MODE
  • TENANT_MASTER

To improve code clarity, a more consistent approach should be taken.
@ghost ghost added the maintenance Things need to be changed to prevent future problems. label Jun 29, 2020
@ghost ghost added the 0 - Backlog New issue, unvetted. label Sep 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
0 - Backlog New issue, unvetted. maintenance Things need to be changed to prevent future problems.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
0 participants