Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tests for Elasticsearch adapter #508

Open
flyaruu opened this issue Oct 3, 2019 · 0 comments
Open

Fix tests for Elasticsearch adapter #508

flyaruu opened this issue Oct 3, 2019 · 0 comments
Labels
0 - Backlog New issue, unvetted.

Comments

@flyaruu
Copy link
Contributor

flyaruu commented Oct 3, 2019

The elasticsearch adapter (we used it for cashless in Sendrato I think) has no meaningful tests. I'd like some tests to insert data into a local index and then assert that the data is actually there.

We can run an Elasticsearch container using circleci. As an example, you can take a look at the mongodb tests, in the Enterprise circleci config we start a mongodb instance for testing as well

We could also consider moving it to enterprise

@ghost ghost added the 0 - Backlog New issue, unvetted. label Sep 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 - Backlog New issue, unvetted.
Projects
None yet
Development

No branches or pull requests

1 participant