Fixes (#72) : Refactor footer component and import it in Intro component #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Great work on the footer refactor—it's looking fantastic. Could you adjust the alignment on the homepage, though? The increased footer height has shifted the "Find Your Perfect Job with JobSewa" line up towards the navbar, which makes the main content feel a bit cramped. Changing this would really help the layout feel more balanced. I'll share a screenshot to illustrate. Thanks for your efforts! |
|
yea sure will work on it |
fixed the issue |
|
i have fixed the issue mentioned in review |
|
can it be merged? |
|
no It is can't able to merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes : #72
This pull request refactors the Footer component to enhance readability and maintainability, and integrates it into the Intro component, ensuring a consistent user interface across the application. Please review the changes.
Before
After
assets, ensuring they are compressed and under 500kb..pngformat and have been directly uploaded—no external image links are used.