Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added partnetTwitterHandle as props and more #283

Merged
merged 4 commits into from
Sep 16, 2024

Conversation

Markkos89
Copy link
Collaborator

Changes

  • added partnerTwitterHandle as props
  • generating a new msg text including it on the createTwitterIntentLink() method
  • typed QuizCompletedModals Props ts interface
  • fixed .mdx content files from oracles-api3 track adding required LessonLayout props
  • updated prisma schema with new field metaImagePath (from academy-t3-app-router repo)

this PR is related to #279

@kempsterrrr TODO: add the new partnerTwitterHandle prop on the neededs QuizStatusChecker component on the .mdx content files.
Also if you want to confirm that information here, I can updated them 😉

@Markkos89 Markkos89 added enhancement New feature or request db related database/prisma related stuff labels Sep 14, 2024
@Markkos89 Markkos89 self-assigned this Sep 14, 2024
Copy link

vercel bot commented Sep 14, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
academy-turbo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 16, 2024 9:31am
academy-turbo-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 16, 2024 9:31am

Copy link
Member

@kempsterrrr kempsterrrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @Markkos89, thanks for making these changes. Please could you add AR.IO's X handle to every lesson before merging - @ar_io_network

might be worth considering if this data should live in the DB in the future - not a priority though as it's quality of life improvement for us > a benefit to the user/customer cc @uma-l

@Markkos89
Copy link
Collaborator Author

Looks good @Markkos89, thanks for making these changes. Please could you add AR.IO's X handle to every lesson before merging - @ar_io_network

might be worth considering if this data should live in the DB in the future - not a priority though as it's quality of life improvement for us > a benefit to the user/customer cc @uma-l

On every lesson or on all ar.io lesson? 🤔
can you confirm @kempsterrrr

@kempsterrrr
Copy link
Member

only the ar.io lessons - so arweave 101 and 201 tracks :)

Copy link

github-actions bot commented Sep 16, 2024

⚡️ Lighthouse report for the changes in this PR:

Category Score
🔴 Performance 36
🟢 Accessibility 96
🟢 Best practices 92
🟢 SEO 92
🟠 PWA 89

Lighthouse ran on https://academy-turbo-git-faet-autotweet-update-developdao.vercel.app/

Copy link
Member

@kempsterrrr kempsterrrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🛳️

@Markkos89 Markkos89 merged commit de436ac into staging Sep 16, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
db related database/prisma related stuff enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants