-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: added partnetTwitterHandle as props and more #283
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good @Markkos89, thanks for making these changes. Please could you add AR.IO's X handle to every lesson before merging - @ar_io_network
might be worth considering if this data should live in the DB in the future - not a priority though as it's quality of life improvement for us > a benefit to the user/customer cc @uma-l
On every lesson or on all ar.io lesson? 🤔 |
only the ar.io lessons - so arweave 101 and 201 tracks :) |
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://academy-turbo-git-faet-autotweet-update-developdao.vercel.app/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🛳️
Changes
partnerTwitterHandle
as propscreateTwitterIntentLink()
methodQuizCompletedModals
Props ts interfaceLessonLayout
propsprisma schema
with new fieldmetaImagePath
(from academy-t3-app-router repo)this PR is related to #279
@kempsterrrr TODO: add the new
partnerTwitterHandle
prop on the neededsQuizStatusChecker
component on the .mdx content files.Also if you want to confirm that information here, I can updated them 😉