-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Visual test #10
base: master
Are you sure you want to change the base?
Visual test #10
Conversation
BreimerR
commented
Mar 20, 2022
NOT TESTED FURTHER
Hi @BreimerR, could you explain your use case? I did a test here and seems that Compose default I think your implementation is perfect to work with applying a base size to the SVG like 32dp is by default, but I think that the name in the Icon should be optional. |
Referenced from: Boiler code reduction.
Becomes
|
I don't think this is a good solution for removing boilerplate, Icons generation generation alot alot alot of code generation that can ingress code size to just not use Modifier.size(). |
I still think your PR is awesome but generating multiple icons with difference only on the icon size is not a good a idea in my opinion, but allowing to generate a icon with a specified size would be awesome and this PR also support that. |