DropDownEditor: Detach focus events before attaching new ones (T1238121) #28547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ksercs
changed the title
ksercs
reviewed
Dec 13, 2024
| @@ -457,6 +457,66 @@ QUnit.module('focus policy', () => { | |||
| assert.ok($dropDownEditor.hasClass('dx-state-focused'), 'Widget is focused after click on clearButton'); | |||
| }); | |||
|
|
|||
| QUnit.test('editor should fire onFocusIn once, if fieldTemplate is used', function(assert) { | |||
There was a problem hiding this comment.
Suggested change
| QUnit.test('editor should fire onFocusIn once, if fieldTemplate is used', function(assert) { | |
| QUnit.test('editor should fire onFocusIn once if fieldTemplate is used (T1238121)', function(assert) { |
| ], | ||
| displayExpr: 'name', | ||
| valueExpr: 'id', | ||
| value: 1, |
There was a problem hiding this comment.
Cannot we minimize the test? Now a lot of properties looks excess
marker-dao
force-pushed
the
24_2_selectbox_T1238121
branch
from
35330fe to
7894ae7
Compare
Zedwag
approved these changes
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.