DataGrid - Contrast between icons in the Filter Row menu and their background doesn't comply with WCAG accessibility standards (T1257970) #28522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tongsonbarbs
changed the title
tongsonbarbs
changed the title
Raushen
requested changes
Dec 11, 2024
Raushen
reviewed
Dec 13, 2024
| @@ -2,6 +2,7 @@ import FocusableElement from '../../internal/focusable'; | |||
|
|
|||
| const CLASS = { | |||
| filterMenu: 'dx-filter-menu', | |||
| filterMenuItem: 'dx-menu-item', | |||
There was a problem hiding this comment.
You do not need changes in the testcafe model
Raushen
reviewed
Dec 13, 2024
| @@ -86,12 +86,6 @@ $datagrid-row-focused-bg: null !default; | |||
| $datagrid-hover-bg: null !default; | |||
| $datagrid-row-hovered-color: null !default; | |||
|
|
|||
| /** | |||
| * $name 30. Context menu icon color | |||
There was a problem hiding this comment.
We should not delete Theme Builder variables as them already became a part of public API. Project where these variables are used will be broken.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.