Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TImezone by Abbreviation - Schedule Command #195

Open
benrick opened this issue Jun 7, 2018 · 4 comments
Open

TImezone by Abbreviation - Schedule Command #195

benrick opened this issue Jun 7, 2018 · 4 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@benrick
Copy link
Member

benrick commented Jun 7, 2018

We should allow specifying timezone by abbreviation instead of just an offset on the schedule command

!schedule CEST should do the same thing as !schedule +2.

@benrick benrick added enhancement New feature or request help wanted Extra attention is needed labels Jun 7, 2018
@Nufflee
Copy link

Nufflee commented Jun 7, 2018

I'll try to do this!

@asyncawake
Copy link
Contributor

As ajukraine suggested in chat yesterday, another nice addition would be to get the timezone by city, as in: !schedule

@Nufflee
Copy link

Nufflee commented Jun 11, 2018

@asyncawake Can you open a separate issue for that please?

@asyncawake
Copy link
Contributor

@Nufflee There is now a hangman test class. I created a test for you to code this abbreviation enhancement against. In theory, if you'd like to do that, jst uncomment it and run it against your implementation until it's green.
https://github.com/DevChatter/devchatterbot/blob/master/src/UnitTests/Core/Commands/ScheduleCommandTests/ProcessShould.cs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants