Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Jupyter Notebook #173

Open
GreyElaina opened this issue Mar 20, 2024 · 6 comments · May be fixed by #442
Open

Support for Jupyter Notebook #173

GreyElaina opened this issue Mar 20, 2024 · 6 comments · May be fixed by #442
Labels
language server pylance parity feature that exists in pylance but not pyright / bug specific to our impl of a pylance feature

Comments

@GreyElaina
Copy link
Contributor

still missing now.

@KotlinIsland KotlinIsland added pylance parity feature that exists in pylance but not pyright / bug specific to our impl of a pylance feature help wanted Extra attention is needed language server labels Mar 20, 2024
@DetachHead
Copy link
Owner

looks like the jupyter extension is separate from pylance and also open source: https://github.com/microsoft/vscode-jupyter

does that cover it? or is there some pylance-specific functionality that we need to add?

@GreyElaina
Copy link
Contributor Author

looks like the jupyter extension is separate from pylance and also open source: microsoft/vscode-jupyter

does that cover it? or is there some pylance-specific functionality that we need to add?

When pylance is enabled, code inside notebooks have highlights & intelligence but basedpyright no. i think this part was supported by pylance (closed source XD).

@DetachHead
Copy link
Owner

ah ok, in that case this might be easier than i thought. will look into it when i have time

@DetachHead DetachHead removed the help wanted Extra attention is needed label Apr 17, 2024
This was referenced Jun 18, 2024
@Klaaktu
Copy link

Klaaktu commented Aug 27, 2024

Is this relevant? microsoft/vscode-python#23897
Looks like it's only in main and not in any of the releases.

EDIT: It's in pre-release and Jedi now works in each individual cell.

@DetachHead
Copy link
Owner

i think that's only relevant to language servers that use the python.languageServer setting, which basedpyright doesn't use. i tried that approach in #424 but it didn't work out for the reasons i mentioned there

@HeadCase
Copy link

HeadCase commented Dec 5, 2024

Has anyone figured out a workaround to used basedpyright on python files and fallback to pylance on Jupyter notebooks? Perhaps a filetype association?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
language server pylance parity feature that exists in pylance but not pyright / bug specific to our impl of a pylance feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants