Conda-forge Package

[iamthebot]

Started working on a package for conda-forge here.

I think we'll need a slightly different installation mechanism since in conda-forge we'd need to depend on the npm package there directly (hence having basedpyright use the npm binary from conda-forge).

Would you (the author) be OK with a conda-forge package? This would be very for those of us who prefer to have all dependencies installed as conda packages.

Any suggestions on how we might have basedpyright use another npm (in lieu of using the nodejs_wheel import)? I saw there was a nixos package PR somewhere...

[DetachHead]

happy to support this. i'm not familiar with conda so im not sure how you'd go about it or if the way the nixos package does it could be any inspiration. however if you want to make any changes to basedpyright to make this easier im open to that too.

[iamthebot]

@DetachHead let me do some more investigation and report back on this issue w/ suggestions for any changes to basedpyright needed to enable this. Hope you don't mind if we keep this issue open in the meantime to track the effort here.

[DetachHead]

no problem!

[lucascolley]

@iamthebot @DetachHead could I open a draft PR upstream so that we can ask the conda-forge maintainers about the situation with npm and vendored packages?

[DetachHead]

sure

[danielnachun]

I'm not an official member of the staged-recipes team at conda-forge but have contributed extensively there so I can provide some feedback on how this would probably be easiest to handle in conda-forge. I would strongly prefer if basedpyright provided an option for users to use their own NodeJS installation if they already have one, such as the one available in conda-forge.

There are many other changes/improvements basedpyright has made to pyright aside from using nodejs-wheel to vendor NodeJS so having it in conda-forge would still be great. The apparent hard dependency on nodejs-wheel is just redundant with what conda-forge already provides and would make packaging more difficult.

[DetachHead]

related: #586

fyi basedpyright is already published on npm however it's currently intended for internal use only and is subject to breaking changes. specifically, the basedpyright playground used to rely on it although it now uses a separate browser build instead.

however i believe some of the alternate installation methods maintained by other contributors have started to rely on it so i will try to avoid breaking it. the only change i anticipate making is fixing the command names which are currently pyright and pyright-langserver. i intend to change them to basedpyright and basedpyright-langserver respectively to be consistent with the pypi package. once i've made that change, i will probably consider the npm package to be officially supported.

[danielnachun]

I don't think we actually need the NPM package for conda-forge - the PyPI package should work fine once #586 is implemented.

[lucascolley]

feedstock creation is done. I'll test it out later tonight

[lucascolley]

looks like this issue can be closed now! working at data-apis/array-api-extra#40

[DetachHead]

i want to add it to the install instructions so i'll leave this issue open for now

[DetachHead]

i made a PR adding the install instructions #917 if any of yous want to take a look before i merge it that'd be appreciated. thanks!