Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong Mapping of elements [BUG] mapping of elements in the footer section (usefullinks) is incorrect. #39

Open
gunwant11 opened this issue Oct 1, 2021 · 1 comment

Comments

@gunwant11
Copy link

🙁 Actual behavior

I forked from the main branch and saw this error in my console while make the website responsive.

Screenshot (695)_LI

🙂 Expected behavior

later i tried to find the bug and found this.

Screenshot (698)

also this

Screenshot (700)

Clearly the mapping method is incorrect
in each iteration the same index was being used
Also the json file was not framed properly

🔢 Steps to Reproduce the Problem

I have fixed this issue in my next pull request to the responsive branch😄.
i guess this is the reason why vercel bot denyed the pull request of @Yash-Chauhan09 and others🙁.
Pls fix this issue using my code or anything else its kinda demotivating when u get an error in pull request.

@yashsehgal
Copy link
Contributor

Thanks for raising up this error in the Footer. You can definitely make a footer component responsive in a PR and fix the mapping issue in the other one. ⭐

And for the vercel deployment issue, It's just our team account has expired. You can refer to this comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants