Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix empty values being nulls in ColumnLayoutRelationData #271

Open
BUYT-1 opened this issue Sep 14, 2023 · 0 comments
Open

Fix empty values being nulls in ColumnLayoutRelationData #271

BUYT-1 opened this issue Sep 14, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@BUYT-1
Copy link
Collaborator

BUYT-1 commented Sep 14, 2023

for (std::string& field : row) {
    if (field.empty()) {
        column_vectors[index].push_back(null_value_id);

From src/core/model/table/column_layout_relation_data.cpp. Should instead check for Null::kValue equality.

@BUYT-1 BUYT-1 added the bug Something isn't working label Sep 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant