Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parser identifying ward/division by "first match", rather than "best match"? #911

Closed
robgilliam opened this issue Apr 7, 2019 · 7 comments
Assignees

Comments

@robgilliam
Copy link

In Halton BC election for 2019-05-02, parser has added details for candidates for Broadheath ward as candidates for Heath ward (the latter appears later in the PDF).

@robgilliam
Copy link
Author

image

@robgilliam
Copy link
Author

image

@robgilliam
Copy link
Author

image

@chris48s
Copy link
Member

chris48s commented Apr 7, 2019

Other examples of incorrect ward matching:

The SoPN parser has mixed up 'Sence Valley' and 'Valley' wards at https://candidates.democracyclub.org.uk/elections/local.north-west-leicestershire.valley.2019-05-02/sopn/
The 'Sence Valley' ward is ok at https://candidates.democracyclub.org.uk/elections/local.north-west-leicestershire.sence-valley.2019-05-02/sopn/

bot seems to have confused "Bulwell" and "Bulwell Forest" wards in Nottingham (https://static-candidates.democracyclub.org.uk/media/official_documents/local.nottingham.sherwood.2019-05-02/statement-of-persons-nominated.pdf)

Bot has picked the wrong ward for Tadcaster, Selby (it picked Camblesforth and Carlton)
https://candidates.democracyclub.org.uk/elections/local.selby.tadcaster.2019-05-02/sopn/

@chris48s
Copy link
Member

chris48s commented Apr 7, 2019

The bot has mistaken 'Swinton North Ward' for 'Winton' when separating the SoPN pages in https://candidates.democracyclub.org.uk/elections/local.salford.winton.2019-05-02/sopn/

@chris48s
Copy link
Member

chris48s commented Apr 7, 2019

The bot has mistaken 'Higham Ward' for 'Trench' when separating the SoPN pages in
https://candidates.democracyclub.org.uk/elections/local.tonbridge-and-malling.trench.2019-05-02/sopn/

@symroe symroe self-assigned this Mar 6, 2020
symroe added a commit that referenced this issue Mar 11, 2020
In combination with 0dc349d this should
catch a load of false positives in the case where one ward's name is a subset
of another ("Heath" and "Broadheath").

Refs #911
symroe added a commit that referenced this issue Apr 3, 2020
In combination with 0dc349d this should
catch a load of false positives in the case where one ward's name is a subset
of another ("Heath" and "Broadheath").

Refs #911
@symroe
Copy link
Member

symroe commented Apr 26, 2021

I'm closing this in favour of #1426 where we have some more recent examples

@symroe symroe closed this as completed Apr 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants