Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename glacier parameter g_tt to g_ttm #309

Open
2 tasks done
JoostBuitink opened this issue Dec 3, 2024 · 2 comments · May be fixed by #310
Open
2 tasks done

Rename glacier parameter g_tt to g_ttm #309

JoostBuitink opened this issue Dec 3, 2024 · 2 comments · May be fixed by #310
Labels
bug Something isn't working needs refinement issue still needs refinement

Comments

@JoostBuitink
Copy link
Collaborator

JoostBuitink commented Dec 3, 2024

HydroMT-Wflow version checks

  • I have checked that this issue has not already been reported.
  • I have checked that this bug exists on the latest version of HydroMT-Wflow.

Reproducible Example

Given the changes in Deltares/Wflow.jl#512, we should update the code and template .toml to reflects these changes

Current behaviour

Parameter is called g_tt

Desired behaviour

Parameter should be called g_ttm

Additional context

No response

@JoostBuitink JoostBuitink added bug Something isn't working needs refinement issue still needs refinement labels Dec 3, 2024
@vers-w
Copy link

vers-w commented Dec 3, 2024

Thanks for reporting this issue @JoostBuitink !

I think the required changes on the hydromt_wflow side affect all model input parameters/variables and parameters/output variables that we want to exchange when we implement standard names for these parameters/variables (Deltares/Wflow.jl#481).

@JoostBuitink
Copy link
Collaborator Author

JoostBuitink commented Dec 3, 2024

Thanks for reporting this issue @JoostBuitink !

I think the required changes on the hydromt_wflow side affect all model input parameters/variables and parameters/output variables that we want to exchange when we implement standard names for these parameters/variables (Deltares/Wflow.jl#481).

Yeah I realized that as well, but wanted to ensure that this one is registered here as well, as it was done as a separate PR. Was indeed thinking about how we should deal with these PRs, merging to master or to a wflow-v1 branch or something. Perhaps something to discuss at one of our standups!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working needs refinement issue still needs refinement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants