Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deriving the outlet and area of waterbodies #182

Open
hboisgon opened this issue Jun 7, 2023 · 0 comments
Open

Deriving the outlet and area of waterbodies #182

hboisgon opened this issue Jun 7, 2023 · 0 comments
Labels
bug Something isn't working workflows Issue linked to the workflows

Comments

@hboisgon
Copy link
Contributor

hboisgon commented Jun 7, 2023

The method that is used to derive waterbodies outlet and area should be improved as it can lead to some wrongful delineation.
So far, we use:

  1. Rasterize waterbody polygon using all_touched = True
  2. Derive the outlet using the cell within the rasterized polygon with max upstream area value

Problem is that with this technique we do not really follow the flow directions so we can include cells in the mask that are part of a different subbasin/tributary. More problematic, in some cases the outlet of the waterbody falls in another basin. Example for the Danube near the sea outlet where a small lake is too close to Danube and the method above then puts the outlet of the lake in the Danube itself (I think this also happens for the Nile in the wetlands part):

image

Not too sure how to improve here but maybe all touched is a little radical to start with so maybe we should exclude cells from the area if the coverage of the cell by the lake is less than a certain threshold like 10%? (there's a nice raster.rasterize_geometry method in core to do that now too). Or used a different rasterization method than all_touched is True?
For the outlet, we should still make sure it falls under the right basin. The 10% filter might already help in some cases but we could also use the watershed area (Wshd_area) ie upstream area column of the waterbody database if they have it for better snapping. This type of snapping is also under dev in PR #172 for gauges.

@hboisgon hboisgon added bug Something isn't working workflows Issue linked to the workflows labels Jun 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working workflows Issue linked to the workflows
Projects
None yet
Development

No branches or pull requests

1 participant