Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass in comments? #36

Open
brandonbrinkley opened this issue May 23, 2023 · 6 comments
Open

Pass in comments? #36

brandonbrinkley opened this issue May 23, 2023 · 6 comments

Comments

@brandonbrinkley
Copy link

When I use DSS manually, I usually have to provide a comment by policy as to why I am retrieving the secret. I assume that this extension task only works with secrets for which that policy is not enabled. My question, would it be possible to add a comment text box to the task config screen and thereby pass in a comment, even if only optional? Obviously, there is no text box for one now, but I think it would be useful to be able to correlate a secret retrieval with a pipeline run in the logs. For example, I could configure it to pass in a string containing the $(Build.BuildId) variable. Thanks!

@cloudkitects
Copy link

I have the same issue, I know the API is capable but I think this would be a great addition and don't want to fork to implement it.

@cloudkitects
Copy link

I forked and tweaked Configuration formatUrl API to pass in comments. I was able to publish the task and test it:

coludkitecs_delineass

@cospeedster
Copy link

Same issue here...

Maybe you can open a PR for that?

@cospeedster
Copy link

@cloudkitects Do you think you can open a PR here?

@cloudkitects
Copy link

@cospeedster my fork has too many branding customizations and it's fairly behind now. I'll try to get to it next month.

@cospeedster
Copy link

@cloudkitects That would be great :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants