Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

the usage of --exp exp(ID) is incorrect #18

Open
hendrikTpl opened this issue May 15, 2023 · 0 comments
Open

the usage of --exp exp(ID) is incorrect #18

hendrikTpl opened this issue May 15, 2023 · 0 comments

Comments

@hendrikTpl
Copy link

hendrikTpl commented May 15, 2023

First of all, thanks for the incredible work and repo you provided. I have a questions and get confused about the path exp ID

I found weird behavior with "plot_loss.py" and "generate.py" when I try to run this script
'python visualization/plot_loss.py --batches 32 --runs kinetic-gan --exp 10' it will generate the loss.pdf inside the folder exp11 (which is not correct, It supposed to be exp10), then I try again using exp11 model to generate the samples
'python generate.py --model runs/kinetic-gan/exp11/models/generator_20000.pth --n_classes 120 --dataset ntu --gen_qtd 1000'
then it is also generate the action samples inside folder exp12

I have checked the code plot_loss.py line#18
out = general.check_runs(opt.runs, id=opt.exp) there is no (opt.exp +1)

and also in generate.py line#24-26

out = general.check_runs('kinetic-gan', id=-1) actions_out = os.path.join(out, 'actions') if not os.path.exists(actions_out): os.makedirs(actions_out)

and I am not sure about the function check_runs line#12-19 in general.py
`def check_runs(method, id=None):
exps_path = os.path.join('runs', method)
if not os.path.exists(exps_path): os.makedirs(exps_path)

exps = [exp for exp in humanSort(os.listdir(exps_path)) if 'exp' in exp]
out  = os.path.join(exps_path,'exp'+str(len(exps)+1)) if not id else os.path.join(exps_path, exps[id])
if not id: os.makedirs(os.path.join(exps_path,'exp'+str(len(exps)+1)))
return out`

any clue why this behavior' occurs?

Thanks in advance

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant