CtInfo: Allow Label Text Selection #337
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A little quality-of-life change to allow selecting the text in the CtInfo dialog with the mouse. This can be useful for quickly getting an install directory path if a user (or a nerd 🤓) wants to get there a little bit quicker. For consistency, all three label values can be selected (the ones on the right, not their parent labels on the left), as even though it's much less common a user would actually select these imo, it would be a bit unexpected if they couldn't.
Selected text can also be dragged from ProtonUp-Qt into other applications, such as a terminal. This may be handy in cases like Steam Deck Game Mode, where if a user needs to visit their Steam installation files, they could more quickly get there.
In addition to, or instead of, we could add an icon button to the right of this label with a "copy to clipboard" type icon, to copy this path, which may be more touchscreen/gamescope friendly (as a small aside, this button would match the UI idea proposed in #336, but I'm getting ahead of myself). This may make the dialog wider than it needs to be though, and may add more clutter than anything else.
The keyboard selection flag was not enabled because it adds a cursor to the label, which looks strange. This however has the downside of not allowing selection changes with Shift+Arrow Keys. Though I think a triple-click to select all is probably the more common use-case for this :-)