Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ML Refactoring #5

Open
4 tasks
surbhigoel77 opened this issue Feb 19, 2024 · 1 comment
Open
4 tasks

ML Refactoring #5

surbhigoel77 opened this issue Feb 19, 2024 · 1 comment
Assignees
Labels
enhancement New feature or request Python-repo Part of the python NN repo

Comments

@surbhigoel77
Copy link
Collaborator

surbhigoel77 commented Feb 19, 2024

  • Move the definition of the train, validation and test datasets, in a separate file (or loaddata.py).
  • In Model.py, condense the hidden layers into a loop instead of repeating
  • Keep the variables' preprocessing out of NN_pred.py file.
  • Restructure from scripts (e.g. use __name__=="main" or notebooks)

NOTE: Given the refactoring, we should add basic tests to ensure that the functioning of the code and inferences remains the same. We also consider adding unit tests as we go along.

@surbhigoel77 surbhigoel77 changed the title Train/test data loading ML Refactoring Feb 19, 2024
@surbhigoel77 surbhigoel77 added the enhancement New feature or request label Feb 19, 2024
@jatkinson1000 jatkinson1000 mentioned this issue Feb 19, 2024
@jatkinson1000 jatkinson1000 added the Python-repo Part of the python NN repo label Feb 26, 2024
@surbhigoel77
Copy link
Collaborator Author

surbhigoel77 commented Mar 4, 2024

Self Note:

The modules loaddata.py and train.py will have no direct interaction with FTorch. FTorch will call the NN_pred.py module to make predictions using the trained models (in the form of torchscripts).

Hence, refactoring of 'loaddata.py' and train.py can be performed in isolation from coupling.

@jatkinson1000 jatkinson1000 mentioned this issue Mar 11, 2024
17 tasks
@mondus mondus mentioned this issue Mar 11, 2024
12 tasks
@omarjamil omarjamil self-assigned this Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Python-repo Part of the python NN repo
Projects
None yet
Development

No branches or pull requests

3 participants