Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

put CDN files to repo #110

Closed
maruilian11 opened this issue Dec 18, 2016 · 10 comments
Closed

put CDN files to repo #110

maruilian11 opened this issue Dec 18, 2016 · 10 comments

Comments

@maruilian11
Copy link

Hi, I'm from cdnjs. Recently we want to add your lib to https://cdnjs.com.
Could you please consider adding buttons.dataTables.min.css and dataTables.buttons.min.js to repo?
like jquery.dataTables.min.css and jquery.dataTables.min.js
So that we can use our git auto-update config to get files from every git tag.
Thank you very much!

cdnjs/cdnjs#10005

@DataTables
Copy link
Collaborator

Hi,

Thanks for your message. Create to hear you want to include this software on cdnjs.

There is another thread in another one of my repos about this: DataTables/FixedHeader#83 . If you have any questions about my replies there I'd be happy to answer them.

@maruilian11
Copy link
Author

maruilian11 commented Dec 19, 2016

@DataTables Thank you for your quick reply.
I think we can use this repo to set up our auto-update config.
https://github.com/DataTables/Dist-DataTables-Buttons/tree/master/js

But there are only js files, I saw you provide buttons.dataTables.min.css on your site.
Is there other repo providing the css file?
Or is it possible also put buttons.dataTables.min.css to DataTables/Dist-DataTables-Buttons?
Thank you!

@DataTables
Copy link
Collaborator

Hi,

The buttons.dataTables.min.css file is in Dist-DataTables-Buttons-DataTables.

The "core" distribution repo contains only the base Javascript. Then you use one of the styling repos (-DataTables, -Bootstrap, etc) to including the styling.

The reason for that was npm. It didn't really provide a way to conditionally select only certain files depending on the style selected.

@maruilian11
Copy link
Author

maruilian11 commented Dec 23, 2016

@DataTables Our auto-update config doesn't support the multiple repo function.
Do you mind if we may need to add these files as two libs?

@DataTables
Copy link
Collaborator

Do you mind if we may need to add these files as two libs?

I'm afraid I don't really understand what that means?

However, I do see how this multiple repo setup can be a bit of a pain for you! I will look into providing the minified files in this repo in the new year.

@maruilian11
Copy link
Author

maruilian11 commented Dec 23, 2016

@DataTables thank you, let will help us a lot!
If you decide not to provide the files, just tag us, we will handle this problem ourself.

Merry Christmas and Happy New Year :)

@kant2002
Copy link

@DataTables did you put files in the repo? CDNjs still missing datatable buttons. Would be good if somebody from CDNjs finally put library in their CDN

@DataTables
Copy link
Collaborator

The files to use on the CDN are in this repo. There are a number of styling repos such as the DataTables one and Bootstrap4 one which should also be used.

@kant2002
Copy link

@DataTables so I assume that I should ping somebody from CDNjs team, so they do what needed on their side. Is this correct?

@AllanJard
Copy link
Contributor

This is a really old issue now - I never followed up at the time - sorry! Buttons can be found on CDNJS here: https://cdnjs.com/libraries/datatables.net-buttons .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants