Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

missing negation - join_kw = "JOIN" if left_outer else "LEFT OUTER JOIN" #2

Open
JWehrstein opened this issue Aug 28, 2023 · 0 comments
Open

missing negation - join_kw = "JOIN" if left_outer else "LEFT OUTER JOIN" #2

JWehrstein opened this issue Aug 28, 2023 · 0 comments

Comments

@JWehrstein
Copy link

JWehrstein commented Aug 28, 2023 •
edited
Loading

zero-shot-cost-estimation/cross_db_benchmark/benchmark_tools/generate_workload.py

Line 208 in 9ceabbd

join_kw = "JOIN" if left_outer else "LEFT OUTER JOIN"

Correct line would be:
join_kw = "JOIN" if not left_outer else "LEFT OUTER JOIN" (not added)
@JWehrstein JWehrstein changed the title missing negation - join_kw = "JOIN" if not left_outer else "LEFT OUTER JOIN" missing negation - join_kw = "JOIN" if left_outer else "LEFT OUTER JOIN" Aug 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@JWehrstein