Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Break package out to not depend on vapor #5

Open
kylebrowning opened this issue May 2, 2023 · 2 comments
Open

Break package out to not depend on vapor #5

kylebrowning opened this issue May 2, 2023 · 2 comments

Comments

@kylebrowning
Copy link

kylebrowning commented May 2, 2023

Some hyper performant applications that are running swift, may not be using vapor. It would be nice if this package didn't depend on a vapor, and there was a new package specifically for vapor so that apps/programs could important the dogstatsd and not have to pull in vapor

@gh123man
Copy link
Member

gh123man commented May 8, 2023

Thanks for the feedback. I was thinking the same. Probably a:

  • Dogstatsd NIO package.
  • Dogstatsd Vapor package that depends on the dogstatsd-NIO

This way users can choose if they want the vapor specific interface, or the lower level library directly on top of NIO. Does this sound good to you?

@kylebrowning
Copy link
Author

Yup, that's exactly what I was thinking.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants