Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: temporarily disable testing on Windows #415

Merged
merged 1 commit into from
Nov 22, 2024

Conversation

RomainMuller
Copy link
Contributor

@RomainMuller RomainMuller commented Nov 22, 2024

For some reason the Windows GitHub runners have become EXTREMELY slow as of late. They used to take 40 minutes (already a pain), and now they're taking > 1h20. This is no longer tolerable.

@RomainMuller RomainMuller requested a review from a team as a code owner November 22, 2024 14:20
@RomainMuller
Copy link
Contributor Author

Maybe related -- actions/runner-images#7320

@RomainMuller RomainMuller added this pull request to the merge queue Nov 22, 2024
@RomainMuller RomainMuller merged commit f9facf2 into main Nov 22, 2024
34 checks passed
@RomainMuller RomainMuller deleted the romain.marcadier/skip-windows-tests branch November 22, 2024 15:18
Copy link

codecov bot commented Nov 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.72%. Comparing base (9cae407) to head (ff1870c).
Report is 13 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #415      +/-   ##
==========================================
+ Coverage   60.31%   63.72%   +3.41%     
==========================================
  Files         179      180       +1     
  Lines       12593    11061    -1532     
==========================================
- Hits         7595     7049     -546     
+ Misses       4500     3487    -1013     
- Partials      498      525      +27     
Components Coverage Δ
Generators 78.12% <ø> (+1.39%) ⬆️
Instruments 73.41% <ø> (-14.65%) ⬇️
Go Driver 80.16% <ø> (+6.22%) ⬆️
Toolexec Driver 73.78% <ø> (+3.11%) ⬆️
Aspects 74.10% <ø> (+2.22%) ⬆️
Injector 74.97% <ø> (+2.75%) ⬆️
Job Server 68.90% <ø> (+6.86%) ⬆️
Integration Test Suite 57.07% <ø> (+2.83%) ⬆️
Other 63.72% <ø> (+3.41%) ⬆️

see 159 files with indirect coverage changes

---- 🚨 Try these New Features:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants