Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flush method not part of interface IDogStatsd #177

Open
UrsMetz opened this issue Jun 20, 2022 · 1 comment
Open

Flush method not part of interface IDogStatsd #177

UrsMetz opened this issue Jun 20, 2022 · 1 comment
Labels

Comments

@UrsMetz
Copy link

UrsMetz commented Jun 20, 2022

The PR #144 added Flush to DogStatsdService but it is not present in the interface IDogStatsd that that service implements. So code that uses the interface instead of the concrete implementation cannot flush without also disposing the service.

@ogaca-dd ogaca-dd added the bug label Sep 23, 2022
@ogaca-dd
Copy link
Contributor

@UrsMetz : Thank you for reporting this issue. Indeed, Flush should be a member of IDogStatsd. I will add Flush to IDogStatsd in the next major release as based from Changes that affect compatibility, adding a member to an interface is a breaking change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants