Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Increased trace ingestion volume after upgrading from 1.67.0 to 1.67.1 #2915

Open
chrisforrette opened this issue Oct 4, 2024 · 3 comments
Labels
bug unintended behavior that has to be fixed

Comments

@chrisforrette
Copy link

Version of dd-trace-go

1.67.1

Describe what happened:

Hello! Upon reviewing our Datadog usage in September we noticed a large spike in trace ingestion volume that started on September 10th, which is when we deployed an update of dd-trace-go from 1.67.0 to 1.67.1. After reverting back to 1.67.0 today, we're now seeing more expected trace volume levels.

I inspected the datadog.estimated_usage.apm.ingested_bytes metric and found that the spike was isolated to one sampling_resource_name value (which was an endpoint of another service that calls this service a lot):

Image

Before the upgrade, this endpoint would generate around 4GB of traces per day and after the upgrade it was generating around 80GB — 100GB a day, which is quite a huge leap.

Also potentially worth noting, when I applied a "sum by" of the sampling_resource_name on the datadog.estimated_usage.apm.ingested_bytes metric, before the upgrade there was a sampling_resource_name:unknown value that was generating around 30GB of traces a day. The value went away when we upgraded and it has now returned after reverting it.

Please let me know if there are any other details that might be helpful to share.

Describe what you expected:

I would expect trace ingestion volume to remain about the same, or based on the 2 PRs included in the changelog:

...the latter PR seems to reduce "resampling" and with my limited understanding of how this library works I might assume lower trace ingestion volume based on that.

Steps to reproduce the issue:

I didn't reproduce this in an isolated way.

Additional environment details (Version of Go, Operating System, etc.):

Go version: 1.23
OS: Alpine linux 3.20.1

Environment variables:

  • DD_TRACE_SAMPLE_RATE: 0.1
  • DD_TRACE_SAMPLING_RULES: [{"service": "primary.db", "sample_rate": 0.03}, {"service": "replica.db", "sample_rate": 0.03}]
@chrisforrette chrisforrette added the bug unintended behavior that has to be fixed label Oct 4, 2024
@github-actions github-actions bot added the needs-triage New issues that have not yet been triaged label Oct 4, 2024
@darccio darccio removed the needs-triage New issues that have not yet been triaged label Oct 8, 2024
@darccio
Copy link
Member

darccio commented Oct 8, 2024

@chrisforrette Thanks for reaching out! Sorry for taking a bit longer than usual to answer. We'll need you to open a support ticket so we can have access to your organization.

In the meantime, we are reviewing the released code to understand better what could lead to this behaviour.

Thanks!

@mtoffl01
Copy link
Contributor

mtoffl01 commented Oct 8, 2024

@chrisforrette
Copy link
Author

@darccio @mtoffl01 OK done! Help request number is: 1879303

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug unintended behavior that has to be fixed
Projects
None yet
Development

No branches or pull requests

3 participants