Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proposal: contrib/segmentio/kafka.go.v0: add WithSpanOptions #2465

Open
balogal opened this issue Dec 21, 2023 · 2 comments
Open

proposal: contrib/segmentio/kafka.go.v0: add WithSpanOptions #2465

balogal opened this issue Dec 21, 2023 · 2 comments
Assignees
Labels
apm:ecosystem contrib/* related feature requests or bugs enhancement quick change/addition that does not need full team approval proposal/accepted Accepted proposals proposal more in depth change that requires full team approval

Comments

@balogal
Copy link

balogal commented Dec 21, 2023

It would be great if contrib/segmentio/kafka.go.v0 would support a WithSpanOptions option for Writer and Reader, similar to e.g. the net/http or contrib/google.golang.org/grpc (see proposal #1125) integrations. In particular, I'm interested in making the spans of the Writer Measured.

@balogal balogal added the enhancement quick change/addition that does not need full team approval label Dec 21, 2023
@github-actions github-actions bot added the needs-triage New issues that have not yet been triaged label Dec 21, 2023
@ajgajg1134 ajgajg1134 added proposal more in depth change that requires full team approval and removed needs-triage New issues that have not yet been triaged labels Dec 21, 2023
@ajgajg1134
Copy link
Contributor

Hello! Thanks for reaching out with this idea! Overall this seems possible, but I'll bring it to the rest of the team to discuss further.

You mentioned wanting to primarily use this to add the Measured option for your Writer, I will note that our FAQ indicates this could be problematic if the reading side of that Kafka topic is also traced.

@balogal
Copy link
Author

balogal commented Dec 27, 2023

Hi @ajgajg1134, thanks for getting back to me so quickly and the hint about measuring client spans. I think, irregardless of the usage of Measured, WithSpanOptions would be a useful addition to the package. (And personally, I would still like to proceed with measuring these spans, accepting the drawbacks).

@darccio darccio added apm:ecosystem contrib/* related feature requests or bugs proposal/accepted Accepted proposals labels Mar 19, 2024
@rarguelloF rarguelloF self-assigned this May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
apm:ecosystem contrib/* related feature requests or bugs enhancement quick change/addition that does not need full team approval proposal/accepted Accepted proposals proposal more in depth change that requires full team approval
Projects
None yet
Development

No branches or pull requests

4 participants