Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide a common interface for power suply control #77

Open
macpijan opened this issue Nov 29, 2024 · 0 comments
Open

Provide a common interface for power suply control #77

macpijan opened this issue Nov 29, 2024 · 0 comments

Comments

@macpijan
Copy link
Contributor

Rather than ifs in the rte.py, we could have a single interface for the power supply control, and implement it for each case (sonoff, rte relay).

macpijan added a commit that referenced this issue Dec 1, 2024
Sonoff returns capital ON/OFF, while relay returned on/off.
We define relay strings here, so can be changed here to
unify the reponses, no matter which power control method
was used at the time.

The more proper solution would be to implement:
#77

Signed-off-by: Maciej Pijanowski <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant