Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't hardcode firmware version and build date #632

Open
filipleple opened this issue Dec 11, 2024 · 0 comments
Open

Don't hardcode firmware version and build date #632

filipleple opened this issue Dec 11, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@filipleple
Copy link
Member

The problem you're addressing (if any)

Right now, we're hardcoding the build date and firmware version into each platform config in the
${DMIDECODE_FIRMWARE_VERSION} and ${DMIDECODE_RELEASE_DATE} flags. This means we have to do trivial edits of the configs for each release/RC.

Describe the solution you'd like

We should come up with a way to do this automatically. I think most if not all could be extracted from the FW file we pass into OSFV. For example:

λ strings protectli_v1610_v0.9.3.rom | grep DMI_DATE
#define COREBOOT_DMI_DATE "09/06/2024"
λ strings protectli_v1610_v0.9.3.rom | grep EXTRA_VERSION
#define COREBOOT_EXTRA_VERSION "-v0.9.3"

to set the date and version, and

λ strings protectli_v1610_v0.9.3.rom | grep -i uefi
EFIVARS: UEFI FV with size %lld found
EFIVARS: UEFI variable store with size %zu found

λ strings optiplex_9010_v0.1.0-rc1_seabios.rom | grep -i uefi
λ

to see if we're dealing with Dasharo (coreboot + EDK2) or Dasharo (coreboot + SeaBIOS)

Where is the value to a user, and who might that user be?

The testers wouldn't have to make trivial changes to the configs each release and PRs with such changes wouldn't have to be handled

Describe alternatives you've considered

Additional context

@filipleple filipleple added the enhancement New feature or request label Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant