WIFI_CARD, WIFI_CARD_UBUNTU Possibly duplicated

[philipandag]

Device

RTE version

OSFV version

develop

Affected component(s) or functionality

MWL, WLE , SMW test suites

Brief summary

WIFI_CARD and WIFI_CARD_UBUNTU seem to be duplicates

How reproducible

100%

How to reproduce

Look at the usages of the keywords in the codebase

Expected behavior

This should be cleaned up a bit. If the WiFi card name is different on Windows, then the variable names should represent, that one of them is only correct on Windows. The two variables should not be used interchangeably as they often have different values assigned in the platform configs. This makes it harder to prepare valid platform configs for tests.

Actual behavior

WIFI_CARD is used to find the wifi card:

• on windows using Get-PnpDevice -PresentOnly | Select-String -Pattern "Wi-Fi" - WLE001.002 Wireless card detection (Windows)
• on Ubuntu using lspci - MWL001.001 Wireless card detection (Ubuntu)

The WIFI_CARD_UBUNTU is used in :

• WLE test suite with lspci - WLE001.001 Wireless card detection (Ubuntu)
• SMW, also with lspci SMW002.001 Wi-fi connection after warm boot (Ubuntu)

The lspci command is also used in different ways across the test cases:

• WLE001.001 Wireless card detection (Ubuntu) - directly with grep
• the whole SMW suite uses lspci directly
• keywords.robot defines Check The Presence Of WiFi Card - as a way to check if the wifi_card is present, duplicated in WLE and SMW

Link to screenshots or logs

No logs needed, issue with the code itself. I believe it can cause issues because the keywords are used interchangeably, but haven't encountered any yet.

Additional context

No response

Solutions you've tried

No response