Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

requirements.txt: update dependencies so they work with Python 3.13 #616

Merged
merged 1 commit into from
Dec 2, 2024
Merged

requirements.txt: update dependencies so they work with Python 3.13 #616

merged 1 commit into from
Dec 2, 2024

Conversation

m-iwanicki
Copy link
Contributor

@m-iwanicki m-iwanicki commented Dec 2, 2024 •
edited
Loading

Previous PR (couldn't reopen): #597

Works with:

telnetlib @ git+https://github.com/3mdeb/telnetlib@b85e3b5e6068eb3441cb21badb5a266301839e61

Should probably also work with https://pypi.org/project/telnetlib-313-and-up/

Quick test:

 robot -L TRACE -v config:qemu -v rte_ip:127.0.0.1 -v snipeit:no dasharo-compatibility/network-boot.robot
==============================================================================
Network-Boot
==============================================================================
PXE001.001 Dasharo Network Boot is available :: This test aims to ... | PASS |
------------------------------------------------------------------------------
PXE002.001 Dasharo network boot menu boot options order is correct... | PASS |
------------------------------------------------------------------------------
PXE003.001 Autoboot option is available and works correctly :: Thi... | PASS |
------------------------------------------------------------------------------

@m-iwanicki m-iwanicki requested a review from macpijan December 2, 2024 10:03
@m-iwanicki m-iwanicki self-assigned this Dec 2, 2024
@m-iwanicki m-iwanicki linked an issue Dec 2, 2024 that may be closed by this pull request
Can't install requirements.txt on Fedora 41, Python 3.13.0 #598
Open
@macpijan
Copy link
Contributor

macpijan commented Dec 2, 2024

Thanks @m-iwanicki !

I have not upgraded Fedora yet, anyone willing to confirm this?

@macpijan macpijan force-pushed the update-requirements-for-python-3-13 branch from b60a4cc to 3cc7500 Compare December 2, 2024 19:15
@macpijan macpijan merged commit 3cc7500 into develop Dec 2, 2024
1 check was pending
@macpijan macpijan deleted the update-requirements-for-python-3-13 branch December 2, 2024 19:15
@macpijan
Copy link
Contributor

macpijan commented Dec 2, 2024

I have upgraded in the meantime and tested in the same way as here: #615

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@macpijan macpijan Awaiting requested review from macpijan

@mysteriousCzrsX mysteriousCzrsX Awaiting requested review from mysteriousCzrsX

@miczyg1 miczyg1 Awaiting requested review from miczyg1

Assignees

@m-iwanicki m-iwanicki

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Can't install requirements.txt on Fedora 41, Python 3.13.0
2 participants
@m-iwanicki @macpijan