Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ambiguous KW on platforms using lib/options/dcu: Boot System Or From Connected Disk #595

Open
philipandag opened this issue Nov 18, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@philipandag
Copy link
Contributor

philipandag commented Nov 18, 2024

Device

RTE version

OSFV version

develop

Affected component(s) or functionality

No response

Brief summary

The Boot System From Connected Disk is defined two times

How reproducible

100%

How to reproduce

Run a test using the keyword on a platform that uses the lib/options/dcu library.

Expected behavior

There are two definitions of the keyword. One which will work on most devices and the other which will work on devices without any power control - which can be rebooted and powered on/off only via the OS.
In both cases the correct definition of the keyword should be used.

Actual behavior

The tests fail because the keyword is defined multiple times.

Link to screenshots or logs

dcu.robot_log.zip

Additional context

Duplicated definition added in 3c5aee7

We are already using multiple definitions of a keyword in the lib/options libraries. the easiest hotfix would be to move the other definition of Boot System Or From Connected Disk to lib/options/uefi-setup-menu.robot, but the keyword has nothing to do with setting the uefi variables. A better solution would be to create libraries for devices which have and don't have some kind of power control, similarly to the lib/options libs. Robot Framework documentation also says something about defining the priority of library files, which might also be useful for solving this issue.
https://robotframework.org/robotframework/latest/RobotFrameworkUserGuide.html#handling-keywords-with-same-names

Solutions you've tried

Temporarily commenting out the keyword which is not supported on the DUT.

@philipandag philipandag added the bug Something isn't working label Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant