Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG: Pet Bouncer incomplete implementation #536

Open
3 tasks done
BrieFlory opened this issue May 3, 2022 · 2 comments · May be fixed by #1305
Open
3 tasks done

BUG: Pet Bouncer incomplete implementation #536

BrieFlory opened this issue May 3, 2022 · 2 comments · May be fixed by #1305
Labels
B-components Related to dGame/dComponents bug Something isn't working P-low This issue can affect gameplay, but does not prevent a user from playing or progressing

Comments

@BrieFlory
Copy link

Make sure you've done the following:

  • I have checked that this issue has not already been reported.

  • I have validated that this issue is not a syntax error of either MySQL or SQLite.

  • I have pulled the latest version of the main branch of DarkflameServer and have confirmed that the issue exists there.

DarkflameServer Version

427c4a8

Issue Description

Pet Bouncers have a variety of inconsistencies with Live that make them feel significantly jankier to interact with.

The current implementation is simple. If a pet is active and you step on the bouncer, the pet will automatically make its way over to the switch and activate it. This behavior is incorrect.

In Live, the pet would make its way to the switch. Then, the player would have the choice of either pressing SHIFT or selecting "Jump" in the Pet Menu to activate the bouncer. Doing so would cost a flat 2 imagination, playing a pet jump animation that syncs up with bouncer activation.

In addition, there are several tutorial popups that don't currently activate the first time around.

On first approach:

image

On first use:

image

After first use:

image

Reproduction Steps

  • Take out your pet
  • Approach pet bouncer
  • Note existing behavior

Expected Behavior

This proper bouncer behavior can be seen in videos from Live:

Lego Universe (Part 23) @ 6:04 (Pet Cove)
https://youtu.be/JHqlfK-NaMA?t=364

image

Lego Universe (Part 52) @ 7:00 (AG Triceratops
https://youtu.be/-9NHizE5jZM?t=420

image

Lego Universe (Part 53) @ 3:00 (AG Monument)
https://youtu.be/uBlemmgjPEE?t=180

Environment

Windows client, Linux server
@BrieFlory BrieFlory added bug Something isn't working triage An issue that needs triage labels May 3, 2022
@EmosewaMC EmosewaMC added P-low This issue can affect gameplay, but does not prevent a user from playing or progressing B-components Related to dGame/dComponents and removed triage An issue that needs triage labels May 3, 2022
@EmosewaMC
Copy link
Collaborator

Related table PetAbilities

@jadebenn
Copy link
Collaborator

Worth noting that a full implementation of pet behavior might obviate the need for the mission check implemented in PR #1287, as the client is most likely already blocking 'shift' button presses prior to mission completion

@jadebenn jadebenn linked a pull request Nov 19, 2023 that will close this issue
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
B-components Related to dGame/dComponents bug Something isn't working P-low This issue can affect gameplay, but does not prevent a user from playing or progressing
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Make pets behave more accurately to Live jadebenn/DarkflameServer
3 participants
@jadebenn @BrieFlory @EmosewaMC