Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Interior Music Update when Teleporting #16

Open
DarianLStephens opened this issue Mar 11, 2023 · 2 comments
Open

Make Interior Music Update when Teleporting #16

DarianLStephens opened this issue Mar 11, 2023 · 2 comments
Labels
bug Something isn't working

Comments

@DarianLStephens
Copy link
Owner

Currently, things like the Ruins music will only be enabled/disabled if you directly go through the actual entrance door.
Teleporting in or out, such as with a Telelocator Staff or Wanda's watches, retains the previous music state.

I had a brief look, but it seems the music updating, and even knowing what music to play in the first place, relies on checking the door for information about the interior.
Theoretically, you could use the dungeon name, at least in part, to determine this (Find a match in the entire string). Otherwise, maybe add a 'music' value to interior data, so we know it directly for every interior?

@DarianLStephens DarianLStephens added the bug Something isn't working label Mar 11, 2023
@DarianLStephens
Copy link
Owner Author

Turns out Hamlet already had code to do exactly that! GetInteriorsByDungeonNameStart
I could do that then compare the name, or maybe copy that code with all its string stuff and just do it to compare the sent interior vs the string?
Or have it compare both the string part and the interior's dungeon_name, directly sent to the function instead of sending it the interior's table?

@Ziwbi
Copy link

Ziwbi commented Jun 15, 2024

Just push the music event for interior music once you have teleported?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants