Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v2 #4

Open
wants to merge 1 commit into
base: ECU
Choose a base branch
from
Open

v2 #4

wants to merge 1 commit into from

Conversation

Skribb11es
Copy link

  • Cleaned up the structure of the repo by moving the class files into a new sub folder named /modules.
  • Fixed issue with requirements.txt not having needed libraries. Namely removing matplotlib as it was not used anywhere, along with adding python-can and tqdm
  • Made a main.py file that consolidates the code found in the DFR_Parser notebook, along with the code of the quick_decoder.py script. (Note, due to some conflicts in operation between the two scripts, there is a terrible chunk of code on lines 33->36 to "convert" the raw dataframe output by the quick_decoder to a format usable by the code written by Reid. Without this snippet, the script will throw an exception that reads "ValueError: cannot reindex on an axis with duplicate labels", to remedy this I just tricked the script into processing the dataframe as if it was originally csv data like Reid designed his code for.)

Copy link

@RMin280 RMin280 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, don't know fix to pandas error. Will look into

Copy link
Contributor

@Squidtoon99 Squidtoon99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you remove these data files? It's bad practice and makes our repository massive. Just rollback and recommit with a proper .gitignore

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants