Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert react component into web component #27

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

nhistory
Copy link

@r2wc/react-to-web-component 라이브러리를 활용해서 리액트 컴포넌트의 스타일 및 props를 웹 컴포넌트로 간단하게 변환

@nhistory nhistory requested a review from a team as a code owner December 27, 2024 18:51
@@ -8,6 +8,7 @@
</head>
<body>
<div id="root"></div>
<wc-button children="Click Me"></wc-button>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

잉? children="Click Me"는 의도하신 건가요?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

넵 현재 Button 컴포넌트 안에서 아래와 같이 children으로 문자를 받아 출력하게끔 지정되어 있습니다.

const WcButton = r2wc(Button, {
  props: {
    children: "string",
  },
});

예를들어 <wc-button>Click Me</wc-button> 이와 같이 작성하면 버튼 안에 Click Me가 출력되지 않습니다.

@r2wc props type은 여기에서 찾아볼 수 있습니다.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<wc-button>Click Me</wc-button>을 되게 만드는 방법은 없나요? children 속성은 상당히 어색하고 일반적으로 예상하기 어려운 API가 될 것 같습니다. Web 컴포넌트와 React 컴포넌트의 API와 최대한 일치해야지 이상적일 것 같아요.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

React 컴포넌트를 웹 컴포넌트로 변환할 수 있는 방법
2 participants