Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case you want them, these are the changes I had to do to make this compile and run on FreeBSD.
This fixes three separate issues:
I used the same prefix/suffix logic as for GCC, except that it has to handle how "clang" is typically in /usr/bin, but the suffixed versions (installed from packages) are typically in /usr/local/bin.
2 and 3 alone should be enough assuming you install gcc first - but the code compiles fine with clang, so that seems unnecessary. In the long run, I guess a cleaner solution would be to respect CC/CPP/CXX if those are set in the environment, and otherwise default to gcc/clang depending on either the OS or just which one is available.