Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

K8S readout consolidation #379

Merged
merged 2 commits into from
Aug 24, 2023
Merged

K8S readout consolidation #379

merged 2 commits into from
Aug 24, 2023

Conversation

alessandrothea
Copy link
Contributor

Moving container attributes for readout from nanorc to daconf.
Also, removes obsolete ND code

plasorak
plasorak approved these changes Aug 24, 2023
View reviewed changes
Copy link
Contributor

@plasorak plasorak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I'm curious to see what the capabilities do.

plasorak
plasorak approved these changes Aug 24, 2023
View reviewed changes
Copy link
Contributor

@plasorak plasorak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, allows us to use any host when use_fake_card is true.

@plasorak plasorak merged commit 30fd67e into develop Aug 24, 2023
2 checks passed
@plasorak plasorak deleted the thea/k8s_consolidation branch August 24, 2023 14:59
dingp added a commit that referenced this pull request Aug 29, 2023
@dingp
syncing dunedaq-develop-cpp-ci.yml; previous commit: Merge: a0fe335 7…
f938b52 
…074e42

Author: Pierre Lasorak <[email protected]>
Date:   Thu Aug 24 15:59:26 2023 +0100

    Merge pull request #379 from DUNE-DAQ/thea/k8s_consolidation

    K8S readout consolidation
dingp added a commit that referenced this pull request Aug 29, 2023
@dingp
syncing ; previous commit: Author: Pengfei Ding <9438483+dingp@users.…
0f8524e 
…noreply.github.com>

Date:   Tue Aug 29 16:30:44 2023 -0500

    syncing dunedaq-develop-cpp-ci.yml; previous commit: Merge: a0fe335 7074e42
    Author: Pierre Lasorak <[email protected]>
    Date:   Thu Aug 24 15:59:26 2023 +0100

        Merge pull request #379 from DUNE-DAQ/thea/k8s_consolidation

        K8S readout consolidation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@plasorak plasorak plasorak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alessandrothea @plasorak