Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return to pool functionality in Administer Workflow #3054

Open
wants to merge 15 commits into
base: main
Choose a base branch
from

Conversation

AndrewAlesik
Copy link

@AndrewAlesik AndrewAlesik commented May 15, 2024

References

Description

In this pull request I provided new functionality to return item to pull in administer workflow.

Instructions for Reviewers

List of changes:

  • First, added function to check if item have pull task.
  • Second, added way to return item from administer workflow.
  • Thirdly, added translations for new variables.

Checklist

This checklist provides a reminder of what we are going to look for when reviewing your PR. You need not complete this checklist prior to creating your PR (draft PRs are always welcome). If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!

  • My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
  • My PR passes ESLint validation using yarn lint
  • My PR doesn't introduce circular dependencies (verified via yarn check-circ-deps)
  • My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
  • My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
  • If my PR includes new libraries/dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
  • If my PR includes new features or configurations, I've provided basic technical documentation in the PR itself.
  • If my PR fixes an issue ticket, I've linked them together.

@tdonohue
Copy link
Member

@AndrewAlesik : Thanks for this contribution. This PR is currently failing lint formatting checks. You can view these locally by running yarn lint and many may be possible to fix automatically by running yarn lint --fix.

@tdonohue tdonohue added improvement component: workflow component: administrative tools Related to the admin menu or tools 1 APPROVAL pull request only requires a single approval to merge and removed 1 APPROVAL pull request only requires a single approval to merge labels May 15, 2024
@AndreiAlesik
Copy link

Hi @tdonohue. Thank you for attention. I provided changes to my code and now it passed lint. Could you review my PR?

Copy link

github-actions bot commented Jun 7, 2024

Hi @AndrewAlesik,
Conflicts have been detected against the base branch.
Please resolve these conflicts as soon as you can. Thanks!

Copy link

Hi @AndrewAlesik,
Conflicts have been detected against the base branch.
Please resolve these conflicts as soon as you can. Thanks!

Copy link

Hi @AndrewAlesik,
Conflicts have been detected against the base branch.
Please resolve these conflicts as soon as you can. Thanks!

@tdonohue
Copy link
Member

tdonohue commented Dec 2, 2024

@AndrewAlesik : Just a quick note that this appears to have lint errors again.

@AndrewAlesik
Copy link
Author

AndrewAlesik commented Dec 11, 2024

Hi @tdonohue, thank you for a hint. I've fixed it and it's ready for a review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: 👀 Under Review
Development

Successfully merging this pull request may close these issues.

Provide a way to restart a workflow on an Item (or "Return to Pool") from Administer Workflow
3 participants