Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

System wide alert does not display in DSpace 8 #3424

Closed
MW3000 opened this issue Oct 15, 2024 · 1 comment · Fixed by #3671
Closed

System wide alert does not display in DSpace 8 #3424

MW3000 opened this issue Oct 15, 2024 · 1 comment · Fixed by #3671
Assignees
@atarix83
Labels
affects: main Issue impacts "main" (latest release). affects: 8.x Issue impacts 8.x releases bug claimed: 4Science 4Science team is working on this issue & will contribute back high priority
Milestone
8.1

Comments

@MW3000
Copy link
Contributor

MW3000 commented Oct 15, 2024 •
edited
Loading

Describe the bug

System wide alert does not display in DSpace 8.x
If you turn on system wide alert and save, it might temporarily show up in your logged in session, but when you check in another browser or logout and reload the site it will not be visible for not logged in users. Sometimes it might flash up for a second and disappear again.

There also is an error message at the browser console. This is taken from https://demo.dspace.org:

[Error] ERROR
Error: undefined is not a valid constructor for {"type":"systemwidealert","alertId":1,"message":"Test the system wide alert feature! New try","countdownTo":null,"active":true,"_links":{"self":{"href":"https://demo.dspace.org/server/api/system/systemwidealerts/1"}}}
(anonymous function) — main.4e36a1fc2ea53912.js:1:118318
(anonymous function) — main.4e36a1fc2ea53912.js:1:1907222
(anonymous function) — main.4e36a1fc2ea53912.js:1:1903613
next — main.4e36a1fc2ea53912.js:1:1892448
(anonymous function) — main.4e36a1fc2ea53912.js:1:1907215
(anonymous function) — main.4e36a1fc2ea53912.js:1:1903613
next — main.4e36a1fc2ea53912.js:1:1892448
(anonymous function) — main.4e36a1fc2ea53912.js:1:1903613
next — main.4e36a1fc2ea53912.js:1:1892448
(anonymous function) — main.4e36a1fc2ea53912.js:1:1907215
(anonymous function) — main.4e36a1fc2ea53912.js:1:1903613
next — main.4e36a1fc2ea53912.js:1:1892448
(anonymous function) — main.4e36a1fc2ea53912.js:1:1897113
(anonymous function) — main.4e36a1fc2ea53912.js:1:1903613
next — main.4e36a1fc2ea53912.js:1:1892448
(anonymous function) — main.4e36a1fc2ea53912.js:1:1905747
(anonymous function) — main.4e36a1fc2ea53912.js:1:1903613
next — main.4e36a1fc2ea53912.js:1:1892448
(anonymous function) — main.4e36a1fc2ea53912.js:1:1907215
(anonymous function) — main.4e36a1fc2ea53912.js:1:1903613
next — main.4e36a1fc2ea53912.js:1:1892448
_subscribe — main.4e36a1fc2ea53912.js:1:1887508
_trySubscribe — main.4e36a1fc2ea53912.js:1:1888252
(anonymous function) — main.4e36a1fc2ea53912.js:1:1888200
c — main.4e36a1fc2ea53912.js:1:1919888
subscribe — main.4e36a1fc2ea53912.js:1:1888103
(anonymous function) — main.4e36a1fc2ea53912.js:1:1888178
c — main.4e36a1fc2ea53912.js:1:1919888
subscribe — main.4e36a1fc2ea53912.js:1:1888103
(anonymous function) — main.4e36a1fc2ea53912.js:1:1907194
(anonymous function) — main.4e36a1fc2ea53912.js:1:1921682
(anonymous function) — main.4e36a1fc2ea53912.js:1:1888155
c — main.4e36a1fc2ea53912.js:1:1919888
subscribe — main.4e36a1fc2ea53912.js:1:1888103
(anonymous function) — main.4e36a1fc2ea53912.js:1:1905689
(anonymous function) — main.4e36a1fc2ea53912.js:1:1921682
(anonymous function) — main.4e36a1fc2ea53912.js:1:1888155
c — main.4e36a1fc2ea53912.js:1:1919888
subscribe — main.4e36a1fc2ea53912.js:1:1888103
(anonymous function) — main.4e36a1fc2ea53912.js:1:1897068
M — main.4e36a1fc2ea53912.js:1:1897200
(anonymous function) — main.4e36a1fc2ea53912.js:1:1897016
M — main.4e36a1fc2ea53912.js:1:1897200
(anonymous function) — main.4e36a1fc2ea53912.js:1:1896942
_trySubscribe — main.4e36a1fc2ea53912.js:1:1888252
(anonymous function) — main.4e36a1fc2ea53912.js:1:1888200
c — main.4e36a1fc2ea53912.js:1:1919888
subscribe — main.4e36a1fc2ea53912.js:1:1888103
(anonymous function) — main.4e36a1fc2ea53912.js:1:1907194
(anonymous function) — main.4e36a1fc2ea53912.js:1:1921682
(anonymous function) — main.4e36a1fc2ea53912.js:1:1888155
c — main.4e36a1fc2ea53912.js:1:1919888
subscribe — main.4e36a1fc2ea53912.js:1:1888103
(anonymous function) — main.4e36a1fc2ea53912.js:1:1905916
(anonymous function) — main.4e36a1fc2ea53912.js:1:1921682
(anonymous function) — main.4e36a1fc2ea53912.js:1:1888155
c — main.4e36a1fc2ea53912.js:1:1919888
subscribe — main.4e36a1fc2ea53912.js:1:1888103
(anonymous function) — main.4e36a1fc2ea53912.js:1:1907194
(anonymous function) — main.4e36a1fc2ea53912.js:1:1921682
(anonymous function) — main.4e36a1fc2ea53912.js:1:1888155
c — main.4e36a1fc2ea53912.js:1:1919888
subscribe — main.4e36a1fc2ea53912.js:1:1888103
(anonymous function) — main.4e36a1fc2ea53912.js:1:1907194
(anonymous function) — main.4e36a1fc2ea53912.js:1:1921682
(anonymous function) — main.4e36a1fc2ea53912.js:1:1888155
c — main.4e36a1fc2ea53912.js:1:1919888
subscribe — main.4e36a1fc2ea53912.js:1:1888103
(anonymous function) — main.4e36a1fc2ea53912.js:1:1897068
M — main.4e36a1fc2ea53912.js:1:1897200
(anonymous function) — main.4e36a1fc2ea53912.js:1:1897016
M — main.4e36a1fc2ea53912.js:1:1897200
(anonymous function) — main.4e36a1fc2ea53912.js:1:1896942
_trySubscribe — main.4e36a1fc2ea53912.js:1:1888252
(anonymous function) — main.4e36a1fc2ea53912.js:1:1888200
c — main.4e36a1fc2ea53912.js:1:1919888
subscribe — main.4e36a1fc2ea53912.js:1:1888103
(anonymous function) — main.4e36a1fc2ea53912.js:1:1907194
(anonymous function) — main.4e36a1fc2ea53912.js:1:1921682
(anonymous function) — main.4e36a1fc2ea53912.js:1:1888155
c — main.4e36a1fc2ea53912.js:1:1919888
subscribe — main.4e36a1fc2ea53912.js:1:1888103
(anonymous function) — main.4e36a1fc2ea53912.js:1:1911414
(anonymous function) — main.4e36a1fc2ea53912.js:1:1903613
next — main.4e36a1fc2ea53912.js:1:1892448
(anonymous function) — main.4e36a1fc2ea53912.js:1:1903613
next — main.4e36a1fc2ea53912.js:1:1892448
(anonymous function) — main.4e36a1fc2ea53912.js:1:1907215
(anonymous function) — main.4e36a1fc2ea53912.js:1:1903613
next — main.4e36a1fc2ea53912.js:1:1892448
(anonymous function) — main.4e36a1fc2ea53912.js:1:1907215
(anonymous function) — main.4e36a1fc2ea53912.js:1:1903613
next — main.4e36a1fc2ea53912.js:1:1892448
(anonymous function) — main.4e36a1fc2ea53912.js:1:1903613
next — main.4e36a1fc2ea53912.js:1:1892448
(anonymous function) — main.4e36a1fc2ea53912.js:1:1907215
(anonymous function) — main.4e36a1fc2ea53912.js:1:1903613
next — main.4e36a1fc2ea53912.js:1:1892448
(anonymous function) — main.4e36a1fc2ea53912.js:1:1897113
(anonymous function) — main.4e36a1fc2ea53912.js:1:1903613
	handleError (main.4e36a1fc2ea53912.js:1:2190754)
	next (main.4e36a1fc2ea53912.js:1:2301833)
	next (main.4e36a1fc2ea53912.js:1:1893068)
	_next (main.4e36a1fc2ea53912.js:1:1892752)
	next (main.4e36a1fc2ea53912.js:1:1892448)
	(anonymous function) (main.4e36a1fc2ea53912.js:1:1890410)
	c (main.4e36a1fc2ea53912.js:1:1919888)
	next (main.4e36a1fc2ea53912.js:1:1890245)
	emit (main.4e36a1fc2ea53912.js:1:2191786)
	run (polyfills.a1b1172df5a5f0a4.js:1:25438)
	onHandleError (main.4e36a1fc2ea53912.js:1:2229518)
	runTask (polyfills.a1b1172df5a5f0a4.js:1:26183)
	invokeTask (polyfills.a1b1172df5a5f0a4.js:1:32046)

To Reproduce

Steps to reproduce the behavior:
You can reproduce on https://demo.dspace.org

  1. Login as admin
  2. Go to System Wide Alert, fill in a system wide alert, enable the alert, click save
  3. Open the site in another browser, or logout and reload
  4. There is no alert displayed
  5. You might get an error message on the browser console

Expected behavior

The system wide alert should display reliable when turned on.
@MW3000 MW3000 added bug needs triage New issue needs triage and/or scheduling labels Oct 15, 2024
@github-project-automation github-project-automation bot moved this to 🆕 Triage in DSpace Backlog Oct 15, 2024
@tdonohue tdonohue added high priority affects: main Issue impacts "main" (latest release). affects: 8.x Issue impacts 8.x releases help wanted Needs a volunteer to claim to move forward and removed needs triage New issue needs triage and/or scheduling labels Oct 15, 2024
@atarix83
Copy link
Contributor

@tdonohue
we can work on this one

@atarix83 atarix83 self-assigned this Nov 15, 2024
@tdonohue tdonohue moved this from 📋 To Do to 🏗 In Progress in DSpace 8.x and 7.6.x Maintenance Nov 15, 2024
@tdonohue tdonohue added claimed: 4Science 4Science team is working on this issue & will contribute back and removed help wanted Needs a volunteer to claim to move forward labels Nov 15, 2024
@tdonohue tdonohue added this to the 8.1 milestone Nov 15, 2024
@alisaismailati alisaismailati mentioned this issue Nov 18, 2024
Merged
12 tasks
@github-project-automation github-project-automation bot moved this from 🏗 In Progress to ✅ Done in DSpace 8.x and 7.6.x Maintenance Nov 18, 2024
@aseyedia aseyedia mentioned this issue Nov 19, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@atarix83 atarix83

Labels
affects: main Issue impacts "main" (latest release). affects: 8.x Issue impacts 8.x releases bug claimed: 4Science 4Science team is working on this issue & will contribute back high priority
Projects
DSpace 8.x and 7.6.x Maintenance
Status: ✅ Done
Milestone
8.1
Development

Successfully merging a pull request may close this issue.

Fixes the display of the System Wide Alert 4Science/dspace-angular
3 participants
@tdonohue @atarix83 @MW3000