Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Author lookup modal causes bitstream titles to disappear in submission form #3291

Closed
jlipka opened this issue Sep 3, 2024 · 1 comment · Fixed by #3378
Closed

Author lookup modal causes bitstream titles to disappear in submission form #3291

jlipka opened this issue Sep 3, 2024 · 1 comment · Fixed by #3378
Assignees
Labels
Milestone

Comments

@jlipka
Copy link

jlipka commented Sep 3, 2024

Describe the bug

In DSpace there is a bug when you are in the submission process. The filename of an uploaded bitstream disappears when you use the lookup (modal) to search for an author to create a relationship.

My test was made locally with DSpace in version 8, the same error occurs in the sandbox (sandbox.dspace.org) with Version 9.

To reproduce

  1. Login (using a account/role which is allowed to create any new item)
  2. Create a new item in any collection that contains an author lookup (e.g. "Publications > Publications 2").
  3. Upload an arbitrary file (see screenshot 1 with its red marker - all is well after uploading)
  4. Open the author lookup modal by clicking on the search icon
  5. Click any checkbox next to a person
  6. Now the bitstream title has disappeared (see screenshot 2 with the red marker at same place - the title next to the file size is gone)

If more than one file was uploaded, the title/filename of all bitstreams will disappear.

Expected behavior

The process of creating a relationship (using the lookup modal) should not cause the filename(s) of any previously uploaded bitstreams to disappear.

Screenshots

1

dspace-upload-bug-1

2

dspace-upload-bug-2

@jlipka jlipka added bug needs triage New issue needs triage and/or scheduling labels Sep 3, 2024
@github-project-automation github-project-automation bot moved this to 🆕 Triage in DSpace Backlog Sep 3, 2024
@tdonohue tdonohue added component: submission affects: 8.x Issue impacts 8.x releases help wanted Needs a volunteer to claim to move forward and removed needs triage New issue needs triage and/or scheduling labels Sep 3, 2024
@tdonohue tdonohue removed this from DSpace Backlog Sep 3, 2024
@DanGastardelli
Copy link
Contributor

Hello, I made a "pull request - #3378" with a modification that would solve this issue. Instead of using the "fileName" variable that is having an undefined value when opening the data insertion modal, I used the visualization component itself to clearly show the title and the weight of the file being processed. This way the text does not disappear with changes in the submission form.

I await feedback,
Daniel Pais (Neki-it)

@tdonohue tdonohue moved this from 📋 To Do to 🏗 In Progress in DSpace 8.x and 7.6.x Maintenance Oct 2, 2024
@github-project-automation github-project-automation bot moved this from 🏗 In Progress to ✅ Done in DSpace 8.x and 7.6.x Maintenance Oct 30, 2024
@tdonohue tdonohue added this to the 8.1 milestone Oct 30, 2024
@tdonohue tdonohue removed the help wanted Needs a volunteer to claim to move forward label Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
3 participants