Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Color contrast in Submit button on New item form is not sufficient #2912

Closed
reetagithub opened this issue Apr 9, 2024 · 3 comments
Closed
Assignees
Labels
accessibility bug component: submission good first issue This is a smaller ticket/bug that may be easier for new contributors help wanted Needs a volunteer to claim to move forward testathon Reported by a tester during Community Testathon

Comments

@reetagithub
Copy link
Contributor

To reproduce this, you can either WAVE the page (a static accessibility testing tool, an addon to the browser) of insert the hexadecimal values of the colors to WebAIM's ContrastChecker.

Related work
#2715 handles sccessibility enhancenents of the UI

@reetagithub reetagithub added bug needs triage New issue needs triage and/or scheduling labels Apr 9, 2024
@github-project-automation github-project-automation bot moved this to 🆕 Triage in DSpace Backlog Apr 9, 2024
@tdonohue
Copy link
Member

tdonohue commented Apr 9, 2024

I believe this is related to the "+ Deposit" button on the Submission form.

While I cannot seem to get WAVE to throw a contrast error on that button (at least it doesn't work with my Chrome plugin), I have been able to verify that the contrast is failing via https://webaim.org/resources/contrastchecker/

The background of that button is #92c642 while the foreground text is white #FFFFFF. This fails the contrast checker above.
On hover over, the background changes to #7ead34 and the foreground text remains white. This also seems to fail.

One possible quick fix might be to change the text to black (#000000)

Needs a volunteer.

@tdonohue tdonohue added component: submission testathon Reported by a tester during Community Testathon help wanted Needs a volunteer to claim to move forward and removed needs triage New issue needs triage and/or scheduling labels Apr 9, 2024
@tdonohue tdonohue removed this from DSpace Backlog Apr 9, 2024
@tdonohue tdonohue moved this to 📋 To Do in DSpace 8.0 Release Apr 9, 2024
@tdonohue tdonohue added the good first issue This is a smaller ticket/bug that may be easier for new contributors label Apr 11, 2024
@michdyk michdyk self-assigned this Apr 12, 2024
@pcg-kk
Copy link
Contributor

pcg-kk commented Apr 19, 2024

Hi, the color for the .btn.btn-success is different.

Currently, it is:
image

As the $success is #92c642 but darken means: #5a7c26
image

This means that the contrast is over 4.5:1:
image

@michdyk michdyk moved this from 📋 To Do to 🏗 In Progress in DSpace 8.0 Release Apr 22, 2024
@tdonohue
Copy link
Member

@pcg-kk : You are correct. Somehow I was looking at the wrong style/color here.

On the submission form, the "+ Deposit" button has a #5a7c26 background with white text. That passes color contrast. When you hover over it, the background gets even darker (#3e551a).

So, this appears to already be solved. Closing, as this is no longer a bug.

@tdonohue tdonohue closed this as not planned Won't fix, can't repro, duplicate, stale Apr 22, 2024
@github-project-automation github-project-automation bot moved this from 🏗 In Progress to ✅ Done in DSpace 8.0 Release Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility bug component: submission good first issue This is a smaller ticket/bug that may be easier for new contributors help wanted Needs a volunteer to claim to move forward testathon Reported by a tester during Community Testathon
Projects
None yet
Development

No branches or pull requests

4 participants