Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve CodeQL alert for "Unvalidated dynamic method call" #2889

Closed
tdonohue opened this issue Apr 4, 2024 · 0 comments · Fixed by #2897
Closed

Resolve CodeQL alert for "Unvalidated dynamic method call" #2889

tdonohue opened this issue Apr 4, 2024 · 0 comments · Fixed by #2897
Assignees
Milestone

Comments

@tdonohue
Copy link
Member

tdonohue commented Apr 4, 2024

Describe the bug
In our Angular 16 upgrade PR #2871, GitHub's CodeQL scanner noted a possible "Unvalidated dynamic method call" error: https://github.com/DSpace/dspace-angular/pull/2871/checks?check_run_id=23429832711

The error is noted on this line of code:

See also https://github.com/DSpace/dspace-angular/security/code-scanning/131 (This link may only work for Committers)

This alert needs to be addressed prior to the 8.0 final release. Assigning to @atarix83 as he / his team added this code.

Related work
Alert first appeared in #2871, but the code was first added in #2750 .

@github-project-automation github-project-automation bot moved this to 📋 To Do in DSpace 8.0 Release Apr 4, 2024
@tdonohue tdonohue moved this from 📋 To Do to 🏗 In Progress in DSpace 8.0 Release Apr 4, 2024
@tdonohue tdonohue added this to the 8.0 milestone Apr 4, 2024
@atarix83 atarix83 mentioned this issue Apr 5, 2024
8 tasks
tdonohue added a commit that referenced this issue Apr 10, 2024
@github-project-automation github-project-automation bot moved this from 🏗 In Progress to ✅ Done in DSpace 8.0 Release Apr 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: ✅ Done
Development

Successfully merging a pull request may close this issue.

2 participants