Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DSpace 7: submission forms issue with check for mandatory fields #2742

Open
f-rapp opened this issue Jan 16, 2024 · 1 comment
Open

DSpace 7: submission forms issue with check for mandatory fields #2742

f-rapp opened this issue Jan 16, 2024 · 1 comment
Labels
bug component: submission help wanted Needs a volunteer to claim to move forward

Comments

@f-rapp
Copy link

f-rapp commented Jan 16, 2024

Describe the bug
Submission forms: A qualdrop-value field which is marked as mandatory is not accepted by DSpace as "present", although a value was entered.

In the example:
The fields dc.contributor.author, field dc.contributor.illustrator are combined into a qualdrop_value field.

The illustrator is given, but the qualdrop_value field is not accepted as "present"
Enter dc.contributor.author instead, and the qualdrop_value field is accepted as "present".

The problem seems to be another mandatory dc.contributor.author field which is present in the same submission forms. However, this other field has other type-bind value and thus should not be considered by DSpace when checking for mandatory fields.

Version 7.6.1, Mozilla Firefox

To Reproduce
Steps to reproduce the behavior:

  1. Add the following section to your submission-forms.xml:
<row>		   	   
	<field>
		<dc-schema>dc</dc-schema>
		<dc-element>contributor</dc-element>
		<dc-qualifier></dc-qualifier>
		<repeatable>true</repeatable>
		<label>Autor / Illustrator</label>
		<input-type value-pairs-name="ContributorTypes">qualdrop_value</input-type>
		<hint></hint>
		<required>mandatory</required>
		<type-bind>Book</type-bind>
		 </field>
</row>
<row>
		 <field>
		<dc-schema>dc</dc-schema>
		<dc-element>contributor</dc-element>
		<dc-qualifier></dc-qualifier>
		<repeatable>true</repeatable>
		<label>Author</label>
		<input-type>onebox</input-type>
		<hint></hint>
		<required>mandatory</required>
		<type-bind>Article</type-bind>
		 </field>
</row>

as well as the value-pairs

  <value-pairs value-pairs-name="ContributorTypes" dc-term="">
    <pair>
      <displayed-value>Author</displayed-value>
      <stored-value>author</stored-value>
    </pair>
    <pair>
      <displayed-value>Illustrator</displayed-value>
      <stored-value>illustrator</stored-value>
    </pair>
  </value-pairs>
  1. Choose the modified submission forms and select Type (dc.type) = Book.
  2. Enter an illustrator, auto-save and check whether DSpace accepts the field as "present".
  3. Then enter an author instead, auto-save and check whether DSpace accepts the field as "present".

Expected behavior
The mandatory qualdrop_value field is accepted as "present" as soon as one value is entered.

Related work

@f-rapp f-rapp added bug needs triage New issue needs triage and/or scheduling labels Jan 16, 2024
@github-project-automation github-project-automation bot moved this to 🆕 Triage in DSpace Backlog Jan 16, 2024
@tdonohue
Copy link
Member

Several bugs appear to exist related to qualdrop fields. Linking these all together as related as they might be claimed/fixed together.

Also another ticket related to the mandatory field check: #2572

Moving this to the 7.6.x maintenance board in search of volunteer

@tdonohue tdonohue added help wanted Needs a volunteer to claim to move forward component: submission and removed needs triage New issue needs triage and/or scheduling labels Jan 16, 2024
@tdonohue tdonohue moved this to 🙋 Needs Reviewers Assigned in DSpace 8.x and 7.6.x Maintenance Jan 16, 2024
@tdonohue tdonohue moved this from 🙋 Needs Reviewers Assigned to 📋 To Do in DSpace 8.x and 7.6.x Maintenance Jan 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug component: submission help wanted Needs a volunteer to claim to move forward
Projects
Development

No branches or pull requests

2 participants