Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider replacing Klaro cookie consent tool, as it seems unmaintained & less accessible #2718

Closed
tdonohue opened this issue Dec 18, 2023 · 4 comments · Fixed by #3199
Closed
Assignees
Labels
accessibility claimed: 4Science 4Science team is working on this issue & will contribute back code task e/20 Estimate in hours funded Task is funded via the DSpace Development Fund new feature
Milestone

Comments

@tdonohue
Copy link
Member

As of this ticket creation, the Klaro cookie consent tool hasn't had a new release since 2021: https://github.com/klaro-org/privacy-manager/releases/tags

It also has some known accessibility issues which haven't been addressed: klaro-org/klaro-js#100

We should consider replacing it with Orejime, which was originally a fork of Klaro, but continues to be maintained as an open source project. It has also has a focus on accessibility. https://github.com/empreinte-digitale/orejime#readme

This migration likely shouldn't be too complex as the two look similar in nature. But, it likely should occur in a major release as all DSpace users will likely need to re-consent to the new cookie consent tool.

@atarix83
Copy link
Contributor

atarix83 commented Jul 1, 2024

@tdonohue @hostle83

4science is interested in working on this task and the related one #2491

Estimation is about 20h

@tdonohue
Copy link
Member Author

tdonohue commented Jul 1, 2024

@atarix83 : Thanks, assigning to you. I would like to understand what approach you plan to take for potentially replacing Klaro.

Since this ticket was created, it looks like Klaro has had some minor releases. But none of them seem to improve accessibility. Orejime still seems to have accessibility improvements, but it hasn't seen a new release since 2022. But, it does seem to have people supporting it on GitHub (as its issues seem to get answers: https://github.com/empreinte-digitale/orejime/issues)

I basically wanted to verify the solution you are going with. Orejime still seems promising, but there may be even better solutions out there (I haven't looked around for a while).

Nonetheless, I'll assign this to you and add the initial estimate. If the estimate needs later updates, let us know.

@tdonohue tdonohue added e/20 Estimate in hours claimed: 4Science 4Science team is working on this issue & will contribute back funded Task is funded via the DSpace Development Fund and removed help wanted Needs a volunteer to claim to move forward labels Jul 1, 2024
@tdonohue tdonohue moved this from 📋 To Do to 🏗 In Progress in DSpace 9.0 Release Jul 1, 2024
@AndreaBarbasso
Copy link
Contributor

@tdonohue, after some research we decided to proceed with Orejime, since it's a fork of Klaro and is the only project we found with decent support (as you said, issues seem to get answers, and pretty fast nonetheless) that has a focus on a11y.

@tdonohue
Copy link
Member Author

Thanks for letting me know, @AndreaBarbasso . That sounds reasonable.

tdonohue added a commit that referenced this issue Nov 8, 2024
[#2718] Migrate cookie consent from Klaro to Orejime
@github-project-automation github-project-automation bot moved this from 🏗 In Progress to ✅ Done in DSpace 9.0 Release Nov 8, 2024
@tdonohue tdonohue added this to the 9.0 milestone Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility claimed: 4Science 4Science team is working on this issue & will contribute back code task e/20 Estimate in hours funded Task is funded via the DSpace Development Fund new feature
Projects
Status: ✅ Done
Development

Successfully merging a pull request may close this issue.

3 participants