Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Accessibility] Empty (invisible) buttons appear on /community-list #2697

Closed
tdonohue opened this issue Dec 6, 2023 · 0 comments · Fixed by #2717
Closed

[Accessibility] Empty (invisible) buttons appear on /community-list #2697

tdonohue opened this issue Dec 6, 2023 · 0 comments · Fixed by #2717
Assignees
Labels
accessibility bug claimed: Atmire Atmire team is working on this issue & will contribute back medium priority
Milestone

Comments

@tdonohue
Copy link
Member

tdonohue commented Dec 6, 2023

Describe the bug
Originally reported in #2055 (comment)

If you use the WAVE browser plugin on the /community-list page, it will report several "Empty button" errors. NOTE: These errors will only be reported for Communities which have displayed "short description" text under the Community name.

These are invisible buttons which have no text or aria-label. They are not seen as errors by all accessibility tools though (e.g. they are not detected by the Deque Axe DevTools browser plugin).

To Reproduce
Steps to reproduce the behavior:

  1. Reproducible on the demo site at https://demo.dspace.org/community-list (or with any local site using our demo entities data set)
  2. Enable the WAVE browser plugin on the page. You will see a number of "Empty button" Errors reported. (The exact number of errors depends on the number of communities displayed)
    • Click on the "Details" and view only those "Empty Button" errors (deselect everything else)
    • You'll see the errors come from any Community in the list which has a "short description" displayed.

Expected behavior
No errors should occur. It's likely these buttons simply need to have an aria-label or some similar descriptive text, so that they are no longer seen as empty. Alternatively, these buttons could be removed from the page (as they are invisible) if doing so does not impact page behavior.

Related work
Related to #2055, where it was originally reported.

@tdonohue tdonohue added bug help wanted Needs a volunteer to claim to move forward accessibility medium priority labels Dec 6, 2023
@tdonohue tdonohue added the good first issue This is a smaller ticket/bug that may be easier for new contributors label Dec 6, 2023
@alexandrevryghem alexandrevryghem added claimed: Atmire Atmire team is working on this issue & will contribute back and removed help wanted Needs a volunteer to claim to move forward good first issue This is a smaller ticket/bug that may be easier for new contributors labels Dec 15, 2023
@alexandrevryghem alexandrevryghem self-assigned this Dec 15, 2023
@alexandrevryghem alexandrevryghem moved this from 📋 To Do to 🏗 In Progress in DSpace 8.x and 7.6.x Maintenance Dec 15, 2023
@github-project-automation github-project-automation bot moved this from 🏗 In Progress to ✅ Done in DSpace 8.x and 7.6.x Maintenance Jan 31, 2024
@tdonohue tdonohue added this to the 7.6.2 milestone Jan 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility bug claimed: Atmire Atmire team is working on this issue & will contribute back medium priority
Projects
Development

Successfully merging a pull request may close this issue.

2 participants