Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shibboleth login often fails on redirect back to DSpace #2669

Closed
artlowel opened this issue Nov 29, 2023 · 2 comments · Fixed by #2670
Closed

Shibboleth login often fails on redirect back to DSpace #2669

artlowel opened this issue Nov 29, 2023 · 2 comments · Fixed by #2670
Assignees
Labels
authentication: Shibboleth related to integration with Shibboleth bug high priority performance / caching Related to performance, caching or embedded objects
Milestone

Comments

@artlowel
Copy link
Member

Describe the bug
When you try to log in using Shibboleth, you'll often notice you're not logged in when you get redirected to DSpace. When this happens you'll see console errors with messages like "undefined doesn't contain the link …", that indicate something is going wrong with calls to retrieve the links on /api

Note that this is a timing issue so it doesn't happen every time, but well over 50% of the time in my tests

To Reproduce

  1. Log in using Shibboleth
  2. When you're redirected back to DSpace, you'll notice you're not logged in and there are errors with messages like "undefined doesn't contain the link …" in the console

Expected behavior
You should be logged in, and there should be no console errors

Related work
This has the same cause as #1027. #1056 fixed it for Dataservices, but not for the HALEndpointService. That wasn't a problem because HAL endpoint requests were never set to stale, until #2510 changed that in 7.6.1. It's also the reason why I couldn't get invalidateRootCache to work when listenForRouteChanges was first called: it caused HALEndpointService to return stale requests, but I didn't realize that's what was happening at the time

@artlowel artlowel added bug authentication: Shibboleth related to integration with Shibboleth performance / caching Related to performance, caching or embedded objects needs triage New issue needs triage and/or scheduling labels Nov 29, 2023
@artlowel artlowel self-assigned this Nov 29, 2023
@github-project-automation github-project-automation bot moved this to 🆕 Triage in DSpace Backlog Nov 29, 2023
@tdonohue tdonohue moved this from 📋 To Do to 🏗 In Progress in DSpace 8.x and 7.6.x Maintenance Nov 29, 2023
@tdonohue tdonohue added high priority and removed needs triage New issue needs triage and/or scheduling labels Nov 29, 2023
@artlowel artlowel linked a pull request Nov 29, 2023 that will close this issue
8 tasks
@mspalti
Copy link
Member

mspalti commented Dec 1, 2023

We were seeing this issue. I applied the changes in #2670 and logins started to succeed. However, after logging into a collection recent submissions don't appear without a page reload. I see #2670 is in draft mode now so perhaps you are aware of this problem @artlowel . fyi

@tdonohue
Copy link
Member

tdonohue commented Jan 8, 2024

Closing, fixed by #2670 and #2731

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
authentication: Shibboleth related to integration with Shibboleth bug high priority performance / caching Related to performance, caching or embedded objects
Projects
Development

Successfully merging a pull request may close this issue.

3 participants