Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

delete metadatafields from multiple metadataschema #2599

Closed
floriangantner opened this issue Nov 6, 2023 · 1 comment · Fixed by #2652
Closed

delete metadatafields from multiple metadataschema #2599

floriangantner opened this issue Nov 6, 2023 · 1 comment · Fixed by #2652
Assignees
Labels
bug claimed: Atmire Atmire team is working on this issue & will contribute back component: administrative tools Related to the admin menu or tools medium priority
Milestone

Comments

@floriangantner
Copy link
Contributor

floriangantner commented Nov 6, 2023

Describe the bug
There is some inconsistency in deleting metadatafields among multiple schemas. When fields from multiple metadataschemas are ticked/selected than these ticks are not shown after browsing through other schemas and multiple fields are deleted.

We discovered the bug in Dspace Cris aligned to Dspace 7.5 where the functionality of the code should not have been modified a lot and we did not found some similar issue in this board describing this behavior. If someone from the community might confirm that this behavior can be reproduced in recent Dspace?

To Reproduce
Steps to reproduce the behavior:

  1. Create dc.aa and dcterms.aab fields (or some other names/schemas of your choice)
  2. Go to metadataschema registry
  3. Go to dc schema and tick ✔️ dc.aa
  4. Go back to the metadataregistry using the back button
  5. Go to dc vocabulary and confirm that the field dc.aa is not marked
  6. Go back to metadataschema registry using the back button
  7. Go to dcterms vocabulary and tick ✔️ dcterms.aab
  8. Click the delete button and wait for the response. It should say that two fields were deleted
  9. Checking the browser console there should be two DELETE Requests

Screencast of steps 2 to 8 (without mouse pointer):
Screencast from 06.11.2023 12:49:33.webm

Expected behavior
We are not sure if the intended behavior is that metadatafields can only be deleted among one metadataschema at once
(in this case the first selected schema is wrong and the selection should be reset when going back, e.g. by deselectingAllMetadataField when the component is destroyed (

this.paginationService.clearPagination(this.config.id);
))
or
that the metadatafields can be selected and deleted among all metadataschemas (in this case the selected ticks are not shown correctly after browsing though multiple schemas).

Related work

@floriangantner floriangantner added bug needs triage New issue needs triage and/or scheduling labels Nov 6, 2023
@github-project-automation github-project-automation bot moved this to 🆕 Triage in DSpace Backlog Nov 6, 2023
@tdonohue
Copy link
Member

tdonohue commented Nov 6, 2023

This sounds like a bug. It should not be possible to delete fields in several schemas at the same time. Once you leave the edit schema page to go to a different schema, the prior selected fields should be reset. It sounds like that's not occurring, which would mean this is a bug.

@tdonohue tdonohue added component: administrative tools Related to the admin menu or tools medium priority help wanted Needs a volunteer to claim to move forward and removed needs triage New issue needs triage and/or scheduling labels Nov 6, 2023
@tdonohue tdonohue removed this from DSpace Backlog Nov 6, 2023
@alexandrevryghem alexandrevryghem moved this from 📋 To Do to 🏗 In Progress in DSpace 8.x and 7.6.x Maintenance Nov 18, 2023
@alexandrevryghem alexandrevryghem added claimed: Atmire Atmire team is working on this issue & will contribute back and removed help wanted Needs a volunteer to claim to move forward labels Nov 18, 2023
@alexandrevryghem alexandrevryghem self-assigned this Nov 18, 2023
@github-project-automation github-project-automation bot moved this from 🏗 In Progress to ✅ Done in DSpace 8.x and 7.6.x Maintenance Nov 23, 2023
@tdonohue tdonohue added this to the 7.6.2 milestone Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug claimed: Atmire Atmire team is working on this issue & will contribute back component: administrative tools Related to the admin menu or tools medium priority
Projects
3 participants