Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenSearch autodiscovery tag is incorrect. #791

Open
heathergreerklein opened this issue Jul 13, 2020 · 1 comment · May be fixed by #2475
Open

OpenSearch autodiscovery tag is incorrect. #791

heathergreerklein opened this issue Jul 13, 2020 · 1 comment · May be fixed by #2475
Assignees
Labels
bug component: Discovery related to discovery search or browse system Difficulty: Low Estimated at less than 8 hours e/2 Estimate in hours good first issue This is a smaller ticket/bug that may be easier for new contributors help wanted Needs a volunteer to claim to move forward high priority

Comments

@heathergreerklein
Copy link

heathergreerklein commented Jul 13, 2020

From release plan spreadsheet

Estimate from release plan: 2 hours
Expressing interest: none

Just needs an HTML section for Angular for autodiscovery. See https://github.com/dewitt/opensearch/blob/master/opensearch-1-1-draft-6.md#autodiscovery Add these tags using the metadata service

Depends on REST ticket DSpace/DSpace#2869

@heathergreerklein heathergreerklein added Difficulty: Low Estimated at less than 8 hours component: Discovery related to discovery search or browse system low priority labels Jul 13, 2020
@heathergreerklein heathergreerklein added this to the 7.2 milestone Jul 13, 2020
@heathergreerklein heathergreerklein added the e/2 Estimate in hours label Jul 20, 2020
@tdonohue tdonohue removed this from the 7.2 milestone Oct 29, 2021
@tdonohue
Copy link
Member

After double checking, this appears to already exist, but the autodiscovery tag is slightly incorrect. So, I'm re-categorizing this as a bug. The feature already exists in 7.6, but doesn't quite work properly.

Here's the docs for autodiscovery: https://github.com/dewitt/opensearch/blob/master/opensearch-1-1-draft-6.md#autodiscovery

Currently, DSpace already generates an OpenSearch servicedocument. It's available at:
[dspace.server.url]/opensearch/service.

However, the HTML header includes an autodiscovery tag which is slightly incorrect. It looks like this on our demo site:

<link href="https://api7.dspace.org/server/opensearch/search/service" type="application/atom+xml" rel="search" title="Dspace">

There are two issues:

So, the correct link tag should look like this:

<link href="https://[dspace.server.url]/opensearch/service" type="application/opensearchdescription+xml" rel="search" title="Dspace">

@tdonohue tdonohue added bug good first issue This is a smaller ticket/bug that may be easier for new contributors labels Jun 28, 2023
@tdonohue tdonohue changed the title OpenSearch API OpenSearch autodiscovery tag is incorrect. Jun 28, 2023
@tdonohue tdonohue added the help wanted Needs a volunteer to claim to move forward label Jun 28, 2023
@J4bbi J4bbi self-assigned this Sep 4, 2023
@J4bbi J4bbi linked a pull request Sep 5, 2023 that will close this issue
@tdonohue tdonohue moved this from 📋 To Do to 🏗 In Progress in DSpace 8.x and 7.6.x Maintenance Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug component: Discovery related to discovery search or browse system Difficulty: Low Estimated at less than 8 hours e/2 Estimate in hours good first issue This is a smaller ticket/bug that may be easier for new contributors help wanted Needs a volunteer to claim to move forward high priority
Projects
Status: 🏗 In Progress
Development

Successfully merging a pull request may close this issue.

3 participants