Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Deque Analysis] Community/Collection Homepage "serious" issues #1178

Closed
tdonohue opened this issue May 11, 2021 · 1 comment · Fixed by #2587
Closed

[Deque Analysis] Community/Collection Homepage "serious" issues #1178

tdonohue opened this issue May 11, 2021 · 1 comment · Fixed by #2587
Labels
accessibility bug component: Collection Collection display or editing component: Community Community display or editing medium priority
Milestone

Comments

@tdonohue
Copy link
Member

tdonohue commented May 11, 2021

Serious: This issue results in serious barriers for people with disabilities, and will partially prevent them from accessing fundamental features or content. People relying on assistive technologies will experience significant frustration as a result. Issues falling under this category are major problems, and remediation should be a priority.

Deque Analysis Summary

Community & Collection homepages have a total of 8 serious issues (not including color contrast which are handled in other tickets). These have been grouped into one ticket because they are similar issues on both pages.

  1. (ID 469493, 469644) (BOTH pages) "Text should not be marked as a heading" on the "Permanent URI for this.." text on both pages. In both cases this text is an <h2>, but it is obviously not heading text. It probably should just be normal text (e.g. <p> tag or similar)
  2. (ID 469552, 469655) (BOTH pages) "Selected state of the element is missing or incorrect." on the currently selected browse by option (e.g. "Subcommunities and Collections" on Community homepage, "Recent Submission" on Collection homepage). In both cases, the selected option is displayed visually, but not noted in ARIA tags.
  3. (ID 470094, 470956) (BOTH pages) "Link contrast is not at least 3:1 with surrounding text." on the Handle link at the top of both pages.
  4. (ID 470257) Community homepage doesn't appear to have a <title>. It keeps the title of the last page. (This issue doesn't appear on the Collection hompage)
  5. (ID 470963) "Content is lost at 320px width" occurs on the pagination bar (page numbers) when a large number of pages exist on a Collection homepage (e.g. https://demo7.dspace.org/collections/282164f5-d325-4740-8dd1-fa4d6d3e7200). Simply put, this bar doesn't collapse nice on small screens...likely it should add a "..." between most pages as the screen gets smaller.
    • NOTE: This is obviously a general pagination issue that can affect this same pagination bar on other pages.
    • UPDATE: No longer reproducible in 7.6.1

Full list of issues is viewable at (requires login): https://axeauditor.dequecloud.com/test-run/0856438a-a19a-11eb-bc31-b7d5be387c86/issues?activeTab=dt-issue&page=0&pageSize=50&sortField=ordinal&sortDir=asc&row=9&filter%5Bseverity%5D=3&filter%5Btype%5D=issue&filter%5Bpage_number%5D=4&filter%5Bpage_number%5D=5

More Information / Tools

@tdonohue
Copy link
Member Author

tdonohue commented Dec 6, 2023

Updated this ticket to be closed by #2587, as that will solve the outstanding Color Contrast issues.

Once Color Contrast is solved, the only remaining issue involves the Browse By Tabs. I've moved that issue to a separate ticket so that it can be addressed/tracked separate from this larger ticket. See #2700

In summary this ticket will be closed as fixes as soon as #2587 is merged. #2700 will be addressed in a separate ticket.

@tdonohue tdonohue moved this from 📋 To Do to 🏗 In Progress in DSpace 8.x and 7.6.x Maintenance Dec 6, 2023
@github-project-automation github-project-automation bot moved this from 🏗 In Progress to ✅ Done in DSpace 8.x and 7.6.x Maintenance Jan 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility bug component: Collection Collection display or editing component: Community Community display or editing medium priority
Projects
Development

Successfully merging a pull request may close this issue.

2 participants