From 24ad516c29232e90e76449c35f65e4508172afc3 Mon Sep 17 00:00:00 2001
From: FrancescoMolinaro <francesco.molinaro@4science.com>
Date: Wed, 27 Dec 2023 10:32:03 +0100
Subject: [PATCH 1/2] fix dropdown overflow and bar z-index

---
 .../ldn-service-form/ldn-service-form.component.html        | 6 +++---
 .../ldn-service-form/ldn-service-form.component.scss        | 6 ++++--
 2 files changed, 7 insertions(+), 5 deletions(-)

diff --git a/src/app/admin/admin-ldn-services/ldn-service-form/ldn-service-form.component.html b/src/app/admin/admin-ldn-services/ldn-service-form/ldn-service-form.component.html
index 16fed56ca4e..124dd307e2a 100644
--- a/src/app/admin/admin-ldn-services/ldn-service-form/ldn-service-form.component.html
+++ b/src/app/admin/admin-ldn-services/ldn-service-form/ldn-service-form.component.html
@@ -251,7 +251,7 @@ <h2 class="flex-grow-1">{{ isNewService ? ('ldn-create-service.title' | translat
             <div class="col">
               <div #outboundPatternDropdown="ngbDropdown" class="w-100" id="additionalOutboundPattern{{i}}"
                    ngbDropdown
-                   placement="bottom-start">
+                   placement="top-start">
                 <div class="position-relative right-addon" role="combobox">
                   <i aria-hidden="true" class="position-absolute scrollable-dropdown-toggle"
                      ngbDropdownToggle></i>
@@ -266,7 +266,7 @@ <h2 class="flex-grow-1">{{ isNewService ? ('ldn-create-service.title' | translat
                     type="text"
                   />
                   <div aria-labelledby="outboundPatternDropdownButton"
-                       class="dropdown-menu scrollable-dropdown-menu w-100 "
+                       class="dropdown-menu dropdown-menu-top w-100 "
                        ngbDropdownMenu>
                     <div class="scrollable-menu" role="listbox">
                       <button (click)="selectOutboundPattern(pattern, i); $event.stopPropagation()"
@@ -355,7 +355,7 @@ <h2 class="flex-grow-1">{{ isNewService ? ('ldn-create-service.title' | translat
 
     <div
       (click)="addOutboundPattern()"
-      class="add-pattern-link mb-4">{{ 'ldn-new-service.form.label.addPattern' | translate }}
+      class="add-pattern-link mb-5">{{ 'ldn-new-service.form.label.addPattern' | translate }}
     </div>
 
 
diff --git a/src/app/admin/admin-ldn-services/ldn-service-form/ldn-service-form.component.scss b/src/app/admin/admin-ldn-services/ldn-service-form/ldn-service-form.component.scss
index 91666cde50c..bace82b2097 100644
--- a/src/app/admin/admin-ldn-services/ldn-service-form/ldn-service-form.component.scss
+++ b/src/app/admin/admin-ldn-services/ldn-service-form/ldn-service-form.component.scss
@@ -129,13 +129,15 @@ textarea {
   bottom: 0;
   background-color: var(--bs-gray-400);
   padding: calc(var(--bs-spacer) / 2);
-  z-index: var(--ds-submission-footer-z-index);
+  z-index: calc(var(--ds-submission-footer-z-index) + 1);
 }
 
 .marked-for-deletion {
   background-color: lighten($red, 30%);
 }
 
-
+.dropdown-menu-top, .scrollable-dropdown-menu  {
+  z-index: var(--ds-submission-footer-z-index);
+}
 
 

From 7e25384bca8e8ba90828712da4b6823adee6bb59 Mon Sep 17 00:00:00 2001
From: FrancescoMolinaro <francesco.molinaro@4science.com>
Date: Thu, 11 Jan 2024 16:34:25 +0100
Subject: [PATCH 2/2] adapt ui improvements due to missing outbound patterns

---
 .../ldn-service-form/ldn-service-form.component.html        | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/src/app/admin/admin-ldn-services/ldn-service-form/ldn-service-form.component.html b/src/app/admin/admin-ldn-services/ldn-service-form/ldn-service-form.component.html
index 52b877c0cfe..6b4f8085953 100644
--- a/src/app/admin/admin-ldn-services/ldn-service-form/ldn-service-form.component.html
+++ b/src/app/admin/admin-ldn-services/ldn-service-form/ldn-service-form.component.html
@@ -109,7 +109,7 @@ <h2 class="flex-grow-1">{{ isNewService ? ('ldn-create-service.title' | translat
             <div class="col">
               <div #inboundPatternDropdown="ngbDropdown" class="w-80" display="dynamic"
                    id="additionalInboundPattern{{i}}"
-                   ngbDropdown placement="bottom-start">
+                   ngbDropdown placement="top-start">
                 <div class="position-relative right-addon" role="combobox">
                   <i aria-hidden="true" class="position-absolute scrollable-dropdown-toggle"
                      ngbDropdownToggle></i>
@@ -124,7 +124,7 @@ <h2 class="flex-grow-1">{{ isNewService ? ('ldn-create-service.title' | translat
                     type="text"
                   />
                   <div aria-labelledby="inboundPatternDropdownButton"
-                       class="dropdown-menu scrollable-dropdown-menu w-100 "
+                       class="dropdown-menu dropdown-menu-top w-100 "
                        ngbDropdownMenu>
                     <div class="scrollable-menu" role="listbox">
                       <button (click)="selectInboundPattern(pattern, i); $event.stopPropagation()"
@@ -147,7 +147,7 @@ <h2 class="flex-grow-1">{{ isNewService ? ('ldn-create-service.title' | translat
               <ng-container
                 *ngIf="!!(formModel.get('notifyServiceInboundPatterns')['controls'][i].value.pattern)">
                 <div #inboundItemfilterDropdown="ngbDropdown" class="w-100" id="constraint{{i}}" ngbDropdown
-                     placement="bottom-start">
+                     placement="top-start">
                   <div class="position-relative right-addon" role="combobox">
                     <i aria-hidden="true" class="position-absolute scrollable-dropdown-toggle"
                        ngbDropdownToggle></i>